feat: add video description into agent func #585

raywhoelse · 2024-05-26T13:46:08Z

Description

Integrate video description into camel agent
refer:https://cookbook.openai.com/examples/gpt_with_vision_for_video_understanding

Motivation and Context

close #567

I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds core functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Documentation (update in the documentation)
Example (update in the folder of example)

Implemented Tasks

Subtask 1
Subtask 2
Subtask 3

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

I have read the CONTRIBUTION guide. (required)
My change requires a change to the documentation.
I have updated the tests accordingly. (required for a bug fix or a new feature)
I have updated the documentation accordingly.

coderabbitai · 2024-05-26T13:46:17Z

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

Wendong-Fan

Thanks @raywhoelse 's contribution! Left some comments in below~

camel/messages/base.py

camel/common/constant.py

camel/messages/base.py

camel/types/enums.py

camel/utils/token_counting.py

camel/messages/base.py

Wendong-Fan

Thanks a lot @raywhoelse ! Left some comments

camel/messages/base.py

camel/utils/constant.py

examples/vision/descripte_video.py

Wendong-Fan

After updating the minor details as mentioned below, it LGTM~

camel/messages/constant.py

examples/vision/descripte_video.py

zechengz

Left some comments

zechengz · 2024-06-10T11:20:45Z

camel/utils/constant.py

+# =========== Copyright 2023 @ CAMEL-AI.org. All Rights Reserved. ===========
+
+
+class Constants:


This name is too general, can we make it more specific?

examples/vision/object_recognition.py

examples/vision/descripte_video.py

camel/messages/base.py

add video description into agent func

51d4f4f

Wendong-Fan assigned raywhoelse May 27, 2024

Wendong-Fan added the New Feature label May 27, 2024

Wendong-Fan added this to the Sprint 4 milestone May 27, 2024

Wendong-Fan linked an issue May 27, 2024 that may be closed by this pull request

[Feature Request] Video input for Agent #567

Closed

2 tasks

Wendong-Fan changed the title ~~add video description into agent func~~ feat: add video description into agent func May 27, 2024

raywhoelse added 3 commits May 27, 2024 21:00

format code arch

9f43c8b

fix issues about code check error

16f09ae

add ignore to huddle image encode

ea007d3

Wendong-Fan requested a review from a team May 29, 2024 13:51

Wendong-Fan reviewed Jun 1, 2024

View reviewed changes

Wendong-Fan requested review from a team and ZackYule June 1, 2024 04:22

raywhoelse added 14 commits June 5, 2024 09:50

change video read method

9651674

fix issues about params

53a2639

format code

45757f9

format code

cc3f4f7

restore OpenAIImageTypeMeta name

bd5d71d

delete OpenAIVideoType

0bb7549

set image detail default is low

3906562

add video detail

763f940

Merge branch 'master' into vision_video_branch

81ba29f

Update pyproject.toml

5bbcc31

format code arch

b1a8a22

Update test_chat_agent.py

dc5677f

add text content in user message

7c32f40

format code

2456878

Wendong-Fan reviewed Jun 7, 2024

View reviewed changes

camel/messages/base.py Outdated Show resolved Hide resolved

camel/messages/base.py Outdated Show resolved Hide resolved

camel/utils/constant.py Outdated Show resolved Hide resolved

examples/vision/descripte_video.py Show resolved Hide resolved

re-format code by comments

ecc6ab8

Wendong-Fan reviewed Jun 9, 2024

View reviewed changes

camel/messages/constant.py Outdated Show resolved Hide resolved

camel/messages/constant.py Outdated Show resolved Hide resolved

examples/vision/descripte_video.py Outdated Show resolved Hide resolved

raywhoelse added 3 commits June 9, 2024 22:32

fix code format by comments

dc67164

add comments

0af5d7d

format code

0ddef87

Wendong-Fan approved these changes Jun 10, 2024

View reviewed changes

zechengz requested changes Jun 10, 2024

View reviewed changes

raywhoelse and others added 9 commits June 11, 2024 10:36

fix issues by zecheng comments

efec5c1

format code

67cff2b

fix issues by zecheng comments

0321aa8

change params by comments

21d2d1f

Merge branch 'master' into ray_task

54b1b0b

set video path as youtube common video

15a249c

Merge branch 'master' into vision_video_branch

0623909

format code

ecaae8e

quick fix

34754b9

Wendong-Fan merged commit 849896c into master Jun 14, 2024
6 checks passed

Wendong-Fan deleted the ray_task branch June 14, 2024 16:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add video description into agent func #585

feat: add video description into agent func #585

raywhoelse commented May 26, 2024 •

edited by Wendong-Fan

Loading

coderabbitai bot commented May 26, 2024 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

Wendong-Fan left a comment

Wendong-Fan left a comment

Wendong-Fan left a comment

zechengz left a comment

zechengz Jun 10, 2024

		# =========== Copyright 2023 @ CAMEL-AI.org. All Rights Reserved. ===========


		class Constants:

feat: add video description into agent func #585

feat: add video description into agent func #585

Conversation

raywhoelse commented May 26, 2024 • edited by Wendong-Fan Loading

Description

Motivation and Context

Types of changes

Implemented Tasks

Checklist

coderabbitai bot commented May 26, 2024 • edited Loading

Review skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

Wendong-Fan left a comment

Choose a reason for hiding this comment

Wendong-Fan left a comment

Choose a reason for hiding this comment

Wendong-Fan left a comment

Choose a reason for hiding this comment

zechengz left a comment

Choose a reason for hiding this comment

zechengz Jun 10, 2024

Choose a reason for hiding this comment

raywhoelse commented May 26, 2024 •

edited by Wendong-Fan

Loading

coderabbitai bot commented May 26, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)