[MRG] Use correct re.sub signature #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`text_strip` currently passes the regex flags as the count parameters, which is hardcoded to `re.UNICODE` (value 32), and thus only replaces the first 32 values. see https://docs.python.org/3/library/re.html#re.sub for the signature
|
Thanks for catching and fixing this! |
|
Closing and reopening to see if it triggers a Travis build. |
|
Looks like Travis has changed a bunch of settings, let me see how to get it to work. |
|
Ok trying again. |
vinayak-mehta
changed the title
|
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
text_stripcurrently passes the regex flags as the count parameters, which is hardcoded tore.UNICODE(value 32), and thus only replaces the first 32 values.see https://docs.python.org/3/library/re.html#re.sub for the signature