Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: confirm invoice missing params #320

Merged
merged 1 commit into from
May 25, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/@types/services.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ export interface IPaymentsService {
updateInvoice(invoice: Partial<Invoice>): Promise<void>
updateInvoiceStatus(invoice: Pick<Invoice, 'id' | 'status'>): Promise<Invoice>
confirmInvoice(
invoice: Pick<Invoice, 'id' | 'amountPaid' | 'confirmedAt'>,
invoice: Pick<Invoice, 'id' | 'amountPaid' | 'confirmedAt' | 'status' | 'pubkey'>,
): Promise<void>
sendInvoiceUpdateNotification(invoice: Invoice): Promise<void>
getPendingInvoices(): Promise<Invoice[]>
Expand Down
2 changes: 2 additions & 0 deletions src/controllers/callbacks/opennode-callback-controller.ts
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,8 @@ export class OpenNodeCallbackController implements IController {
try {
await this.paymentsService.confirmInvoice({
id: invoice.id,
pubkey: invoice.pubkey,
status: updatedInvoice.status,
amountPaid: updatedInvoice.amountRequested,
confirmedAt: updatedInvoice.confirmedAt,
})
Expand Down
3 changes: 3 additions & 0 deletions src/controllers/callbacks/zebedee-callback-controller.ts
Original file line number Diff line number Diff line change
Expand Up @@ -70,11 +70,14 @@ export class ZebedeeCallbackController implements IController {
}

invoice.amountPaid = invoice.amountRequested
invoice.status = updatedInvoice.status
updatedInvoice.amountPaid = invoice.amountRequested

try {
await this.paymentsService.confirmInvoice({
id: invoice.id,
pubkey: invoice.pubkey,
status: invoice.status,
confirmedAt: invoice.confirmedAt,
amountPaid: invoice.amountRequested,
})
Expand Down