Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Engine: implement timeout with Go instead of external program #17

Closed
4 tasks
camerondurham opened this issue Jan 27, 2022 · 0 comments
Closed
4 tasks
Assignees
Labels
runtime Engine runtime handles safely executing user submitted code

Comments

@camerondurham
Copy link
Owner

Currently, the runner uses the Linux timeout (from the coreutils homebrew formula on macOS) command to execute commands with a timeout.

This is to improve execution by using multiple channels and select to implement the timeout in Go. See gobyexample/timeouts for an example.

Acceptance Criteria (in progress):

  • run command with configurable X second timeout
    • look at other options to implement timeout in Go
    • explore if we can use select with exec.Command instead of the timeout external process
    • test functionality in unit tests
siwei-li added a commit that referenced this issue Jan 29, 2022
Modify runtime.go and merge private function `runCommand` into `runCmd`

Issue #17
camerondurham pushed a commit that referenced this issue Jan 29, 2022
Modify runtime.go and merge private function `runCommand` into `runCmd`

Issue #17
@camerondurham camerondurham added the runtime Engine runtime handles safely executing user submitted code label Feb 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
runtime Engine runtime handles safely executing user submitted code
Projects
Development

No branches or pull requests

2 participants