Media domain support for switch_to_blog() #97
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A rethink of the
DM_Media
to get it working withswitch_to_blog()
. Media domains functionality is now more aware of the context switches and now has the capability to retrieve settings on a per site basis and recall them when needed.Also
DarkMatter_Domains
no longer has a hard requirement for theDM_NETWORK_MEDIA
constant to be the only way to hard-code the media domains. UsingDarkMatter_Domains::instance()->network_media
property now affords the opportunity for more sophisticated logic to be applied - for example: someone could theoretically group sites together and serve them on a specific set of CDN domains for media assets. This is now easier to achieve that running the risk of accidentally defining theDM_NETWORK_MEDIA
constant more than once.This PR resolves the following unit test errors / warnings:
Fixes: #91