parse REAL literals to convenient form #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raehik
force-pushed
the
real-lit-parsing
branch
2 times, most recently
from
1de87b0
to
0b1fa7e
Compare
raehik
force-pushed
the
real-lit-parsing
branch
from
0b1fa7e
to
c69c34d
Compare
|
This e.g. lets Camfort support the various Fortran-style real literals (instead of trying to read as a Haskell real), and fortran-vars not do any extra parsing work. |
|
@dominic would you be able to give this a quick look over? I'll bring it on Mon otherwise. It's largely adapted from some other code I wrote before but now gets called during parsing (actually, during lexing for free form, parsing for fixed form -- I stuck with the existing patterns) |
raehik
force-pushed
the
real-lit-parsing
branch
from
c69c34d
to
67b3655
Compare
|
Oops, I'd already said I wasn't around Monday. I'm preparing other changes around this so it can all merge quick and smooth when we've discussed it. |
We decompose REALs to their respective parts (significand & exponent), but keep the numeric parts as strings to allow the user to select how to represent the value. Along with a printer and parser, we also export a "reader" to convert parsed REAL literals to any compatible Fortran type, so for most uses users will only need that function to turn a Fortran REAL literal into a Haskell value. (Previously, everyone had to implement their own parsing.)
raehik
force-pushed
the
real-lit-parsing
branch
from
67b3655
to
df09a83
Compare
|
Discussed, giving it a merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We decompose REALs to their respective parts (significand & exponent),
but keep the numeric parts as strings to allow the user to select how to
represent the value. Along with a printer and parser, we also export a
"reader" to convert parsed REAL literals to any compatible Fortran type,
so for most uses users will only need that function to turn a Fortran
REAL literal into a Haskell value. (Previously, everyone had to
implement their own parsing.)