Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved the Documentation #413 #478

Merged
merged 1 commit into from
Feb 9, 2021
Merged

Conversation

anumi1999
Copy link
Contributor

Description

**Describe your changes in detail
The code documentation for google login is improved. Meaning of each variable is defined clearly.

Types of changes

**What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

**Go over all the following points, and put an x in all the boxes that apply.
**(If you're unsure about any of these, don't hesitate to ask. We're here to help!)

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Copy link
Member

@birm birm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting choice to document first, but looks reasonable to me. I'm not sure that some of the callback descriptors are necessary, but should be better than not having them. Thanks for taking the time.

@birm birm changed the base branch from master to develop February 9, 2021 14:45
@birm birm merged commit 81442e1 into camicroscope:develop Feb 9, 2021
This was referenced Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants