Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regex validation for email during signup process #501

Merged
merged 1 commit into from
Mar 16, 2021

Conversation

Eddges
Copy link
Contributor

@Eddges Eddges commented Mar 15, 2021

Description

** Regex validation for email in the signup form. The program throws an alert and doesn't proceed to registration.

Motivation and Context

** During user registration, it is possible currently to sign up with an invalid email. I felt adding an email validation with a tried and tested regular expression so the form doesn't accept invalid email might be a good addition.

How Has This Been Tested?

** The regex is based on RFC822 standard, so it covers the entire spectrum of email addresses. I have used the regex from w3resources. So it is expected to work right.
I tested the same code with camicroscope. It works for all the cases. I have used the same code in my earlier projects and it has never caused an issue.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@birm birm changed the base branch from master to develop March 15, 2021 14:58
Copy link
Member

@birm birm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this should hopefully help avoid some confusion

@birm birm merged commit 4a5ec2a into camicroscope:develop Mar 16, 2021
@birm birm mentioned this pull request Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants