Feature for additional links in toolbar #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
birm
requested changes
Apr 1, 2021
|
@birm I've added the error handler. Let me know if that works fine. |
birm
requested changes
Apr 1, 2021
birm
approved these changes
Apr 1, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature for additional links in toolbar of viewer.
Summary
This change provides the ability to put additional links in the toolbar for the slide viewer. This PR should solve #468 . This feature also needs a JSON file which is described in Distro PR-161.
The new links are appended as shown with the green marker.
The links are customizable with the following parameters:
Motivation
Yes it fixes #468
Testing
This has been tested on local system running Ubuntu 18.04, docker-compose version 1.28.6, and Mozilla firefox browser.
Questions