New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update bootstrap in table.html, workbench.html and info.html #519
Conversation
Hey @birm, Is this PR okay? |
Hoping to review soon :) |
Sure. Thanks |
It looks like the slide upload button/modal isn't working among similar issues, does this match your observation? |
Bootstrap 5 is major bump in bootstrap because it has ditched jQuery completely. And camic uses jquery a lot this needs to tested quite extensively I suppose. |
Addition: Workbench uses mdbootstrap so and it has bootstrap 4 as dependency I guess. So things should be tested carefully not just from a UI perspective but from a workflow perspective too. |
Hey, I am also looking into the issue, the problem I am facing is only the slide upload button is not calling the on-click functions. I don't know if the problem is with bootstrap 5 as other buttons are working. |
Luckily, this isn't blocking anything, so we have plenty of time to test! |
Great |
I am on it. |
Hey guys, Things are working fine now... Apparently, bootstrap have updated a few things: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
Summary
Issue: #517
I have updated the bootstrap versions in workbench.html, info.html, table.html files.
Motivation
Testing
Questions