Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bootstrap in table.html, workbench.html and info.html #519

Merged
merged 2 commits into from May 13, 2021

Conversation

Priyaraj17
Copy link
Contributor

@Priyaraj17 Priyaraj17 commented May 10, 2021

Summary

Issue: #517
I have updated the bootstrap versions in workbench.html, info.html, table.html files.

Motivation

Testing

image

Questions

@Priyaraj17
Copy link
Contributor Author

Hey @birm, Is this PR okay?

@birm birm changed the title Updated table.html, workbench.html and info.html Update bootstrap in table.html, workbench.html and info.html May 12, 2021
@birm birm self-requested a review May 12, 2021 02:08
@birm
Copy link
Member

birm commented May 12, 2021

Hoping to review soon :)

@Priyaraj17
Copy link
Contributor Author

Sure. Thanks

@birm
Copy link
Member

birm commented May 12, 2021

It looks like the slide upload button/modal isn't working among similar issues, does this match your observation?

@akhil-rana
Copy link
Contributor

Bootstrap 5 is major bump in bootstrap because it has ditched jQuery completely. And camic uses jquery a lot this needs to tested quite extensively I suppose.

@akhil-rana
Copy link
Contributor

Bootstrap 5 is major bump in bootstrap because it has ditched jQuery completely. And camic uses jquery a lot this needs to tested quite extensively I suppose.

Addition: Workbench uses mdbootstrap so and it has bootstrap 4 as dependency I guess. So things should be tested carefully not just from a UI perspective but from a workflow perspective too.

@Priyaraj17
Copy link
Contributor Author

Hey, I am also looking into the issue, the problem I am facing is only the slide upload button is not calling the on-click functions. I don't know if the problem is with bootstrap 5 as other buttons are working.

@birm
Copy link
Member

birm commented May 12, 2021

Luckily, this isn't blocking anything, so we have plenty of time to test!

@akhil-rana
Copy link
Contributor

Luckily, this isn't blocking anything, so we have plenty of time to test!

Great

@Priyaraj17
Copy link
Contributor Author

I am on it.

@Priyaraj17
Copy link
Contributor Author

Hey guys, Things are working fine now... Apparently, bootstrap have updated a few things:
Earlier versions:
<button type="button" class="btn btn-primary" data-toggle="modal" data-target="#exampleModal"> Launch demo modal </button>
Bootstrap 5:
<button type="button" class="btn btn-primary" data-bs-toggle="modal" data-bs-target="#exampleModal"> Launch demo modal </button>
I have made the necessary changes. I hope I didn't miss anything.

Copy link
Member

@birm birm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@birm birm requested a review from nanli-emory May 13, 2021 18:03
@birm birm merged commit da96f47 into camicroscope:develop May 13, 2021
@birm birm mentioned this pull request Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants