Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Footer to Sign Up Page #635

Merged
merged 1 commit into from Mar 30, 2023
Merged

Conversation

shivanisorte
Copy link
Contributor

Summary
I have added a footer to the sign-up page for improved user experience.
Below are some screenshots

Before

image

image

After

image

image

Motivation
This Pull Request is motivated by the need to make the website consistent with the application's design. All other pages contain the footer.

Testing
I have tested it on different devices and screen sizes to ensure it is fully responsive.

Questions
Shall the footer be added to the home page too? Are there any links that are to be attached to the footer? Are there any additional changes or improvements that could be made?

@birm birm changed the base branch from master to develop March 30, 2023 23:13
Copy link
Member

@birm birm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. At some point we should probably be more visually consistent, but that sounds more like a redesign/refactor for later. Thank you for helping us get there!

@birm birm merged commit f679e26 into camicroscope:develop Mar 30, 2023
@shivanisorte shivanisorte deleted the footer branch March 31, 2023 04:19
This was referenced Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants