Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

images in subdirs #655

Merged
merged 1 commit into from Sep 11, 2023
Merged

images in subdirs #655

merged 1 commit into from Sep 11, 2023

Conversation

CGDogan
Copy link
Contributor

@CGDogan CGDogan commented Sep 6, 2023

Corresponding to camicroscope/SlideLoader#82

@birm
Copy link
Member

birm commented Sep 7, 2023

How should I use this to actually load a dicom image from the ui? Is that pattern batch loader specific?

@CGDogan
Copy link
Contributor Author

CGDogan commented Sep 8, 2023

It calculates a hash from every DICOM file uploaded, a hash of the image identifier and not of the file. Hence if you would like to upload two files making up an image, it doesn't matter how you upload them. You can use the single file uploader and this would work even if you uploaded them with a 10 year delay between them.

Nevertheless still we'll have one entry in the list for each file uploaded even if they make up one image and it doesn't matter which one you click on to show the same image.

Copy link
Member

@birm birm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good; while we'd prefer to have one database entry per slide, we'll need to decide how to do that.

Thank you!

@birm birm merged commit 87fb0a5 into camicroscope:develop Sep 11, 2023
@birm birm mentioned this pull request Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants