add subscriber details

[tomzaragoza]

No description provided.

[coveralls]

Coverage remained the same when pulling afe5c15 on tomzaragoza:createsend-add-subscribers-details into a0fe851 on campaignmonitor:master.

[tobio]

Hey @tomzaragoza,

The wrapper already provides a method to get a subscribers details. I understand that this method is operating on the instance fields which makes sense, but rather than create a new method we'd prefer updating the existing method to use the instance fields if the list_id and email_address arguments aren't supplied.

Something like

  def get(self, list_id=None, email_address=None):
    """Gets a subscriber by list ID and email address."""
    params = { "email": email_address or self.email_address }
    response = self._get("/subscribers/%s.json" % list_id or self.list_id, params=params)
    return json_to_py(response)

[tomzaragoza]

Oh, didn't see that! Shall I update the pull request with your preferred way of updating the method?

[tobio]

All good. Just updating this pull request is fine, any additional commits to your createsend-add-subscribers-details branch should be automatically reflected here.

[coveralls]

Coverage remained the same when pulling 20b7848 on tomzaragoza:createsend-add-subscribers-details into a0fe851 on campaignmonitor:master.

[jdennes]

Could we get an additional test here please?