Move pyramid_beaker a new extra named upload #251
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbrunner
force-pushed
the
beaker-extra
branch
2 times, most recently
from
0f39650
to
847f7a1
Compare
arnaud-morvan
approved these changes
Apr 3, 2023
| try: | ||
| config.include('pyramid_beaker') # use Beaker for session storage | ||
| except ModuleNotFoundError: | ||
| logger.info("""Unable to include pyramid_beaker this probably mean that he is not installer. |
There was a problem hiding this comment.
Shouldn't we log this as warning ?
Suggested change
| logger.info("""Unable to include pyramid_beaker this probably mean that he is not installer. | |
| logger.info("""Unable to include pyramid_beaker this probably mean that it is not installed. |
|
Currently in this project release process is:
Note that, regading your change in CHANGES.txt you might also update version in setup.py and create a tag. We use MAJOR.MINOR.RELEASE. So this might be a 2.1.28 version or 2.2.0 version. Will this be used in GMF 2.7 or 2.8 ? Available for discussion if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix https://jira.camptocamp.com/browse/GSGMF-1987