Skip to content
This repository has been archived by the owner on Jun 6, 2023. It is now read-only.

Layertree ux #15

Merged
merged 12 commits into from
Mar 1, 2012
Merged

Layertree ux #15

merged 12 commits into from
Mar 1, 2012

Conversation

pgiraud
Copy link

@pgiraud pgiraud commented Jan 5, 2012

These commits include an example for the CGXP LayerTree widget.
This was a good point to start with to fix visual issues in IE and to add some UX enhancements.

@asaunier
Copy link
Member

asaunier commented Jan 6, 2012

I have no special comments about the code changes. They look OK.

I have made a few tests in a real project with various browsers (FF9, Chrome, Safari 5.1, IE7-8-9):

  • A bug that is not new and occuring with all browsers: when moving up or down a layergroup, the background layer is switched back to the default one (or the first one in the combo?).
  • With FF, Safari and Chrome, I have noticed no glitch. The new layout of the layergroups is really excellent! Thanks! It's a pity that IE versions do not support those improvements.
  • With IE I have noticed two problems with the layer opacity slider:
  • IE7 + IE8: the layer opacity is not always correct when playing with the opacity cursor: for instance the layer items seem darker on the map when slider value is 99% than 100%
  • IE7 + IE8 + IE9: when playing with the slider cursor, the layer visibility sometimes switches to false (layer disappears) when sliding back to 100%.

Anyway good job! :)

@elemoine
Copy link
Contributor

Where do we stand with this pull request?

I also see that this pull request makes changes to the core css. Is this wanted?

@sbrunner
Copy link
Member

Otherwise it seem good => merge.

@elemoine
Copy link
Contributor

@pgiraud is this good to merge now?

pgiraud pushed a commit that referenced this pull request Mar 1, 2012
Layertree ux display issues fixes and enhancements.
@pgiraud pgiraud merged commit 326bb0b into master Mar 1, 2012
pgiraud pushed a commit to pgiraud/cgxp that referenced this pull request May 21, 2014
noImgCls to control the LegendImage style. r=bbinet
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants