Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code simplifications #4466

Merged
merged 4 commits into from
Dec 15, 2018
Merged

Code simplifications #4466

merged 4 commits into from
Dec 15, 2018

Commits on Dec 13, 2018

  1. Remove (left|right)NavIsVisible function 

    And use the variables directly.
    @fredj
    fredj committed Dec 13, 2018
    Configuration menu
    Copy the full SHA
    974d131 View commit details
    Browse the repository at this point in the history

  2. Remove unseless getters and setter 

    The setters are only setting the value and the getters are only returning the value.
    @fredj
    fredj committed Dec 13, 2018
    Configuration menu
    Copy the full SHA
    facb99b View commit details
    Browse the repository at this point in the history

  3. Use Object.assign instead of ol/obj

    @fredj
    fredj committed Dec 13, 2018
    Configuration menu
    Copy the full SHA
    0075098 View commit details
    Browse the repository at this point in the history

  4. Remove hideSearchOverlay function 

    And use the variable directly.
    @fredj
    fredj committed Dec 13, 2018
    Configuration menu
    Copy the full SHA
    4948217 View commit details
    Browse the repository at this point in the history