Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App desktop #546

Merged
merged 18 commits into from
Jan 25, 2016
Merged

App desktop #546

merged 18 commits into from
Jan 25, 2016

Conversation

pgiraud
Copy link
Contributor

@pgiraud pgiraud commented Jan 22, 2016

A new desktop app is added.
Less files are also reorganized and cleaned up.

https://pgiraud.github.io/ngeo/app_desktop_/examples/contribs/gmf/apps/desktop/?map_zoom=2&map_x=1917652&map_y=3639626
The map doesn't display for Cross Origin issues.

@pgiraud
Copy link
Contributor Author

pgiraud commented Jan 22, 2016

Please note that the styling in the mobile app has also been updated.
https://pgiraud.github.io/ngeo/app_desktop_/examples/contribs/gmf/apps/mobile/?lang=fr

@sbrunner
Copy link
Member

This change duplicate many things in the Makefile, and don't get the resent changes done in the mobile layout...
For me it can be merge as it, and I can fix it later :-)

@pgiraud
Copy link
Contributor Author

pgiraud commented Jan 25, 2016

I agree with the fact that we should factorize a lot of things in the Makefile.

What changes in the mobile layout are you talking about?

@pgiraud
Copy link
Contributor Author

pgiraud commented Jan 25, 2016

The coverage decreased. I don't know what to do though. Is it OK if I merge anyway?

@sbrunner
Copy link
Member

For example this https://github.com/camptocamp/ngeo/pull/546/files#diff-3b3991580353d0e4e9686acb4d4d713aR20 should be in the html file,
This constructor https://github.com/camptocamp/ngeo/pull/546/files#diff-3b3991580353d0e4e9686acb4d4d713a has relay less parameter than in the mobile on, I pretty sure that there is something missing...

@sbrunner
Copy link
Member

Does any one find a way to easily find what's change in the coverage?

@pgiraud pgiraud force-pushed the app_desktop_ branch 2 times, most recently from eb4aa09 to c9aa5fb Compare January 25, 2016 08:58
@pgiraud
Copy link
Contributor Author

pgiraud commented Jan 25, 2016

@sbrunner I made some changes and rebased the pull request.

@pgiraud
Copy link
Contributor Author

pgiraud commented Jan 25, 2016

Travis is happy again for everything but the coverage. @sbrunner can you please give me the final green light?

@sbrunner
Copy link
Member

For me we should defined how we relay want to work with coveralls, then for me you can merge :-)

pgiraud pushed a commit that referenced this pull request Jan 25, 2016
@pgiraud pgiraud merged commit 9a80cd3 into camptocamp:master Jan 25, 2016
@pgiraud pgiraud deleted the app_desktop_ branch January 25, 2016 10:21
@sbrunner sbrunner added this to the Older milestone Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants