-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App desktop #546
App desktop #546
Conversation
Please note that the styling in the mobile app has also been updated. |
This change duplicate many things in the Makefile, and don't get the resent changes done in the mobile layout... |
I agree with the fact that we should factorize a lot of things in the Makefile. What changes in the mobile layout are you talking about? |
The coverage decreased. I don't know what to do though. Is it OK if I merge anyway? |
For example this https://github.com/camptocamp/ngeo/pull/546/files#diff-3b3991580353d0e4e9686acb4d4d713aR20 should be in the html file, |
Does any one find a way to easily find what's change in the coverage? |
eb4aa09
to
c9aa5fb
Compare
@sbrunner I made some changes and rebased the pull request. |
when opening toolbar
Travis is happy again for everything but the coverage. @sbrunner can you please give me the final green light? |
For me we should defined how we relay want to work with coveralls, then for me you can merge :-) |
A new desktop app is added.
Less files are also reorganized and cleaned up.
https://pgiraud.github.io/ngeo/app_desktop_/examples/contribs/gmf/apps/desktop/?map_zoom=2&map_x=1917652&map_y=3639626
The map doesn't display for Cross Origin issues.