Mobile prevent scroll #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have a problem that I don't understand for now. The ngTouch directives don't seem to be taken into account in the hosted examples. |
|
Fixes #399. |
|
Looks good :-) |
pgiraud
force-pushed
the
mobile_prevent_scroll
branch
from
711262e
to
fe3a324
Compare
|
Any idea about why ngTouch directives are not taken into account in built mode? |
|
missing |
| @@ -15,4 +15,4 @@ goog.require('gmf'); | |||
| /** | |||
| * @type {!angular.Module} | |||
| */ | |||
| var appModule = angular.module('app', [gmfModule.name]); | |||
| var appModule = angular.module('app', [gmfModule.name, 'ngTouch']); | |||
pgiraud
force-pushed
the
mobile_prevent_scroll
branch
from
fe3a324
to
3d60086
Compare
|
I prefer leaving the swipe gesture besides for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also closes side navigation when swiping the map.