Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing artifact version of netty-tcnative-boringssl-static #7938

Closed
saig0 opened this issue Oct 6, 2021 · 3 comments · Fixed by #7946
Closed

Missing artifact version of netty-tcnative-boringssl-static #7938

saig0 opened this issue Oct 6, 2021 · 3 comments · Fixed by #7946
Assignees
Labels
kind/bug Categorizes an issue or PR as a bug version:1.3.0 Marks an issue as being completely or in parts released in 1.3.0

Comments

@saig0
Copy link
Member

saig0 commented Oct 6, 2021

Describe the bug
The Maven build of dependent projects fails when updating zeebe-bom to version 1.2.0.

Error:  Failed to execute goal on project zeebe-hazelcast-exporter: 
Could not resolve dependencies for project io.zeebe.hazelcast:zeebe-hazelcast-exporter:jar:1.0.2-SNAPSHOT: 
Could not find artifact io.netty:netty-tcnative-boringssl-static:jar:${tcnative.version} in zeebe (https://app.camunda.com/nexus/content/repositories/zeebe-io/) -> [Help 1]

It seems that the version of the artifact netty-tcnative-boringssl-static can't be resolved. Instead of a version, it has the placeholder ${tcnative.version}.

The zeebe-bom imports the dependency to netty via netty-bom :

<version.netty>4.1.68.Final</version.netty>

      <dependency>
        <groupId>io.netty</groupId>
        <artifactId>netty-bom</artifactId>
        <version>${version.netty}</version>
        <type>pom</type>
        <scope>import</scope>
      </dependency>

/bom/pom.xml

It seems that netty-bom was changed and now includes netty-tcnative-boringssl-static with the placeholder ${tcnative.version}. See here.

 <dependency>
        <groupId>io.netty</groupId>
        <artifactId>netty-tcnative-boringssl-static</artifactId>
        <version>${tcnative.version}</version>
      </dependency>

netty/bom/pom.xml

To Reproduce
Create a Maven project that includes the dependency to zeebe via zeebe-bom.

              <dependency>
                <groupId>io.camunda</groupId>
                <artifactId>zeebe-bom</artifactId>
                <version>1.2.0</version>
                <scope>import</scope>
                <type>pom</type>
            </dependency>

Expected behavior
I can update the Maven dependency without including additional dependencies.

Log/Stacktrace

Full Stacktrace

[INFO] Scanning for projects...
[INFO] Downloading from central: https://repo.maven.apache.org/maven2/io/camunda/zeebe-bom/1.2.0/zeebe-bom-1.2.0.pom
[INFO] Downloaded from central: https://repo.maven.apache.org/maven2/io/camunda/zeebe-bom/1.2.0/zeebe-bom-1.2.0.pom (8.6 kB at 25 kB/s)
[INFO] Downloading from zeebe: https://app.camunda.com/nexus/content/repositories/zeebe-io/io/netty/netty-bom/4.1.68.Final/netty-bom-4.1.68.Final.pom
[INFO] Downloading from central: https://repo.maven.apache.org/maven2/io/netty/netty-bom/4.1.68.Final/netty-bom-4.1.68.Final.pom
[INFO] Downloaded from central: https://repo.maven.apache.org/maven2/io/netty/netty-bom/4.1.68.Final/netty-bom-4.1.68.Final.pom (12 kB at 488 kB/s)
[INFO] Inspecting build with total of 3 modules...
[INFO] Not installing Nexus Staging features:
[INFO]  * Preexisting staging related goal bindings found in 3 modules.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Build Order:
[INFO] 
[INFO] EZE Root                                                           [pom]
[INFO] EZE - Embedded Zeebe Engine                                        [jar]
[INFO] EZE - JUnit Extension                                              [jar]
[INFO] 
[INFO] -------------------< org.camunda.community:eze-root >-------------------
[INFO] Building EZE Root 0.3.1-SNAPSHOT                                   [1/3]
[INFO] --------------------------------[ pom ]---------------------------------
[INFO] 
[INFO] --- maven-clean-plugin:2.6:clean (default-clean) @ eze-root ---
[INFO] 
[INFO] --- jacoco-maven-plugin:0.8.7:prepare-agent (coverage-initialize) @ eze-root ---
[INFO] argLine set to -javaagent:/home/runner/.m2/repository/org/jacoco/org.jacoco.agent/0.8.7/org.jacoco.agent-0.8.7-runtime.jar=destfile=/home/runner/work/eze/eze/target/jacoco.exec
[INFO] 
[INFO] --- fmt-maven-plugin:2.12:format (default) @ eze-root ---
[INFO] Skipping format check: project uses 'pom' packaging
[INFO] 
[INFO] --- kotlin-maven-plugin:1.5.31:compile (compile) @ eze-root ---
Warning:  No sources found skipping Kotlin compile
[INFO] 
[INFO] --- license-maven-plugin:4.1:format (add-license) @ eze-root ---
[INFO] Updating license headers...
[INFO] 
[INFO] --- kotlin-maven-plugin:1.5.31:test-compile (test-compile) @ eze-root ---
Warning:  No sources found skipping Kotlin compile
[INFO] 
[INFO] --- maven-jar-plugin:2.5:jar (empty-javadoc-jar) @ eze-root ---
Warning:  JAR will be empty - no content was marked for inclusion!
[INFO] Building jar: /home/runner/work/eze/eze/target/eze-root-0.3.1-SNAPSHOT-javadoc.jar
[INFO] 
[INFO] --- jacoco-maven-plugin:0.8.7:report (coverage-report) @ eze-root ---
[INFO] Skipping JaCoCo execution due to missing execution data file.
[INFO] Downloaded from central: https://repo.maven.apache.org/maven2/io/netty/netty-handler-proxy/4.1.68.Final/netty-handler-proxy-4.1.68.Final.jar (24 kB at 70 kB/s)
[INFO] Downloading from central: https://repo.maven.apache.org/maven2/io/netty/netty-codec-socks/4.1.68.Final/netty-codec-socks-4.1.68.Final.jar
[INFO] Downloaded from central: https://repo.maven.apache.org/maven2/io/camunda/zeebe-gateway-protocol-impl/1.2.0/zeebe-gateway-protocol-impl-1.2.0.jar (380 kB at 1.1 MB/s)
[INFO] Downloading from central: https://repo.maven.apache.org/maven2/io/netty/netty-tcnative-boringssl-static/$%7Btcnative.version%7D/netty-tcnative-boringssl-static-$%7Btcnative.version%7D.jar
[INFO] Downloaded from central: https://repo.maven.apache.org/maven2/io/netty/netty-codec-http2/4.1.68.Final/netty-codec-http2-4.1.68.Final.jar (471 kB at 1.3 MB/s)
[INFO] Downloading from central: https://repo.maven.apache.org/maven2/io/netty/netty-handler/4.1.68.Final/netty-handler-4.1.68.Final.jar
[INFO] Downloaded from central: https://repo.maven.apache.org/maven2/io/netty/netty-codec-socks/4.1.68.Final/netty-codec-socks-4.1.68.Final.jar (119 kB at 325 kB/s)
[INFO] Downloading from central: https://repo.maven.apache.org/maven2/io/netty/netty-resolver/4.1.68.Final/netty-resolver-4.1.68.Final.jar
[INFO] Downloaded from central: https://repo.maven.apache.org/maven2/io/netty/netty-codec-http/4.1.68.Final/netty-codec-http-4.1.68.Final.jar (634 kB at 1.7 MB/s)
[INFO] Downloading from central: https://repo.maven.apache.org/maven2/io/netty/netty-buffer/4.1.68.Final/netty-buffer-4.1.68.Final.jar
[INFO] Downloaded from central: https://repo.maven.apache.org/maven2/io/camunda/zeebe-gateway-protocol/1.2.0/zeebe-gateway-protocol-1.2.0.jar (6.7 kB at 18 kB/s)
[INFO] Downloading from central: https://repo.maven.apache.org/maven2/io/netty/netty-transport/4.1.68.Final/netty-transport-4.1.68.Final.jar
[INFO] Downloading from central: https://repo.maven.apache.org/maven2/io/netty/netty-codec/4.1.68.Final/netty-codec-4.1.68.Final.jar
[INFO] Downloaded from central: https://repo.maven.apache.org/maven2/io/netty/netty-resolver/4.1.68.Final/netty-resolver-4.1.68.Final.jar (37 kB at 94 kB/s)
[INFO] Downloading from central: https://repo.maven.apache.org/maven2/io/netty/netty-common/4.1.68.Final/netty-common-4.1.68.Final.jar
[INFO] Downloaded from central: https://repo.maven.apache.org/maven2/io/netty/netty-handler/4.1.68.Final/netty-handler-4.1.68.Final.jar (522 kB at 1.2 MB/s)
[INFO] Downloaded from central: https://repo.maven.apache.org/maven2/io/netty/netty-buffer/4.1.68.Final/netty-buffer-4.1.68.Final.jar (302 kB at 708 kB/s)
[INFO] Downloaded from central: https://repo.maven.apache.org/maven2/io/netty/netty-codec/4.1.68.Final/netty-codec-4.1.68.Final.jar (337 kB at 789 kB/s)
[INFO] Downloaded from central: https://repo.maven.apache.org/maven2/io/netty/netty-transport/4.1.68.Final/netty-transport-4.1.68.Final.jar (479 kB at 1.1 MB/s)
[INFO] Downloaded from central: https://repo.maven.apache.org/maven2/io/netty/netty-common/4.1.68.Final/netty-common-4.1.68.Final.jar (653 kB at 1.5 MB/s)
[INFO] Downloading from zeebe: https://app.camunda.com/nexus/content/repositories/zeebe-io/io/netty/netty-tcnative-boringssl-static/$%7Btcnative.version%7D/netty-tcnative-boringssl-static-$%7Btcnative.version%7D.jar
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for EZE Root 0.3.1-SNAPSHOT:
[INFO] 
[INFO] EZE Root ........................................... SUCCESS [  2.181 s]
[INFO] EZE - Embedded Zeebe Engine ........................ FAILURE [  4.986 s]
[INFO] EZE - JUnit Extension .............................. SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  9.352 s
[INFO] Finished at: 2021-10-05T19:23:49Z
[INFO] ------------------------------------------------------------------------
Error:  Failed to execute goal on project eze: Could not resolve dependencies for project org.camunda.community:eze:jar:0.3.1-SNAPSHOT: Could not find artifact io.netty:netty-tcnative-boringssl-static:jar:${tcnative.version} in central (https://repo.maven.apache.org/maven2) -> [Help 1]
Error:  
Error:  To see the full stack trace of the errors, re-run Maven with the -e switch.
Error:  Re-run Maven using the -X switch to enable full debug logging.
Error:  
Error:  For more information about the errors and possible solutions, please read the following articles:
Error:  [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionException
Error:  
Error:  After correcting the problems, you can resume the build with the command
Error:    mvn <args> -rf :eze
Error: Process completed with exit code 1.

Environment:

  • OS:
  • Zeebe Version: 1.2.0
  • Configuration: Maven project
@saig0 saig0 added the kind/bug Categorizes an issue or PR as a bug label Oct 6, 2021
@Zelldon
Copy link
Member

Zelldon commented Oct 6, 2021

issue in the 4.1.68 netty version netty/netty#11691 fixed with 4.1.69

@Zelldon
Copy link
Member

Zelldon commented Oct 6, 2021

Update 4.1.69 is not released yet 🤣

@Zelldon
Copy link
Member

Zelldon commented Oct 6, 2021

ghost pushed a commit that referenced this issue Oct 7, 2021
7946: build: do not include netty in zeebe bom r=deepthidevaki a=deepthidevaki

## Description

Due to a bug in netty, some projects that include zeebe-bom in their dependency encountered build failure. It is not clear why we added netty in zeebe bom. Ideally third party dependencies should not be in the project bom.

## Related issues

closes #7938



Co-authored-by: Deepthi Devaki Akkoorath <deepthidevaki@gmail.com>
@ghost ghost closed this as completed in 86ff291 Oct 7, 2021
ghost pushed a commit that referenced this issue Oct 7, 2021
7947: [Backport stable/1/2] build: do not include netty in zeebe bom r=deepthidevaki a=deepthidevaki

Backport #7946 

closes #7938 



Co-authored-by: Deepthi Devaki Akkoorath <deepthidevaki@gmail.com>
@korthout korthout added the version:1.3.0 Marks an issue as being completely or in parts released in 1.3.0 label Jan 4, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes an issue or PR as a bug version:1.3.0 Marks an issue as being completely or in parts released in 1.3.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants