Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport stable/1.1] Remove listeners to prevent memory leak #7775

Merged
1 commit merged into from
Sep 7, 2021
Merged

[Backport stable/1.1] Remove listeners to prevent memory leak #7775

1 commit merged into from
Sep 7, 2021

Conversation

deepthidevaki
Copy link
Contributor

Description

This is a backport of #7762 , but only one commit from this PR was relevant for the backport.

@deepthidevaki
fix(broker): remove topology listeners when closing stream processor
efdfa11 
After a role transition, StreamProcessor and LogStream instances were not garbage collected due to indirect references from this listener leading to memory leak.
@deepthidevaki
Copy link
Contributor Author

@saig0 This is backport of one commit from the PR #7762 Everything else was introduced in later version. The commit was not cherry-picked as the classes were moved. But the change is exactly the same.

saig0
saig0 approved these changes Sep 7, 2021
View reviewed changes
Copy link
Member

@saig0 saig0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@deepthidevaki
Copy link
Contributor Author

bors r+

@ghost
Copy link

ghost commented Sep 7, 2021

Build succeeded:

@ghost ghost merged commit 1f7bfcf into stable/1.1 Sep 7, 2021
@ghost ghost deleted the backport-7762-to-stable/1.1 branch September 7, 2021 09:41
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2021

Backport failed for stable/1.0, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin stable/1.0
git worktree add -d .worktree/backport-7775-to-stable/1.0 origin/stable/1.0
cd .worktree/backport-7775-to-stable/1.0
git checkout -b backport-7775-to-stable/1.0
ancref=$(git merge-base 9eb54cb27fb9ff61015038ed5d49bde7363c2661 efdfa116d91f0a86f07db3a77be9126513baddb3)
git cherry-pick -x $ancref..efdfa116d91f0a86f07db3a77be9126513baddb3

@deepthidevaki deepthidevaki mentioned this pull request Sep 7, 2021
Merged
ghost pushed a commit that referenced this pull request Sep 7, 2021
@deepthidevaki
merge: #7777
d23494e 
7777: [Backport stable/1.0] Remove listeners to prevent memory leak r=deepthidevaki a=deepthidevaki

## Description

Backport of #7775 

Backport of 4459ea1 from PR #7762 

Co-authored-by: Deepthi Devaki Akkoorath <deepthidevaki@gmail.com>
ghost pushed a commit that referenced this pull request Sep 7, 2021
@deepthidevaki
merge: #7777
2297da4 
7777: [Backport stable/1.0] Remove listeners to prevent memory leak r=deepthidevaki a=deepthidevaki

## Description

Backport of #7775 

Backport of 4459ea1 from PR #7762 

Co-authored-by: Deepthi Devaki Akkoorath <deepthidevaki@gmail.com>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saig0 saig0 saig0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deepthidevaki @saig0 @npepinpe