Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport stable/1.0] Remove listeners to prevent memory leak #7777

Merged
1 commit merged into from
Sep 7, 2021
Merged

[Backport stable/1.0] Remove listeners to prevent memory leak #7777

1 commit merged into from
Sep 7, 2021

Conversation

deepthidevaki
Copy link
Contributor

Description

Backport of #7775

Backport of 4459ea1 from PR #7762

@deepthidevaki
fix(broker): remove topology listeners when closing stream processor
90e8fa0 
After a role transition, StreamProcessor and LogStream instances were not garbage collected due to indirect references from this listener leading to memory leak.
saig0
saig0 approved these changes Sep 7, 2021
View reviewed changes
Copy link
Member

@saig0 saig0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@deepthidevaki
Copy link
Contributor Author

bors r+

ghost pushed a commit that referenced this pull request Sep 7, 2021
@deepthidevaki
merge: #7777
d23494e 
7777: [Backport stable/1.0] Remove listeners to prevent memory leak r=deepthidevaki a=deepthidevaki

## Description

Backport of #7775 

Backport of 4459ea1 from PR #7762 

Co-authored-by: Deepthi Devaki Akkoorath <deepthidevaki@gmail.com>
@ghost
Copy link

ghost commented Sep 7, 2021

Build failed:

@deepthidevaki
Copy link
Contributor Author

bors r+

@ghost
Copy link

ghost commented Sep 7, 2021

Build succeeded:

@ghost ghost merged commit 2297da4 into stable/1.0 Sep 7, 2021
@ghost ghost deleted the backport-7775-to-stable/1.0 branch September 7, 2021 15:19
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saig0 saig0 saig0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deepthidevaki @saig0 @npepinpe