deployment.yaml bug in args

[ricardofmsimoes]

Hi guys

I was trying to use the helm to deploy camunda with rest and webapps only but it wasn't working.
I was not able to set camunda running.

In image section I try things like

image:
  name: camunda/camunda-bpm-platform
  tag: run-latest
  command: ["./camunda.sh"]
  args:
   - --rest
   - --webapps

OR

image:
  name: camunda/camunda-bpm-platform
  tag: run-latest
  command: ["./camunda.sh"]
  args: [--rest, --webapps]

Or Even

image:
  name: camunda/camunda-bpm-platform
  tag: run-latest
  command: ["./camunda.sh"]
  args: ["--rest", "--webapps" ]

Nothing work, in the "final deployment YAML file" the args always become:

args:
  - '--rest --webapps'

I started looking into camunda.sh and start.sh file and I figureout the reason for the camunda not start.
The '--rest --webapps' is interpreted as one arg and not as 2 args.

After a long days trying to find the reason for that args are not being interpreted as 2 args I found an issue on the deployment.yaml file

Here is my conclusion, in the args part in the deployment.yaml file instead of

{{- if .Values.image.args }}
  args: 
    {{ .Values.image.args }}
  {{- end }}

should be:

 {{- if .Values.image.args }}
  args: 
    {{- toYaml .Values.image.args | nindent 12 }}
  {{- end }}

Do you think it is possible to do this change?
Or it will have impact in other use case ?

[aabouzaid]

@ricardofmsimoes It's actually a good catch, thanks for reporting it 🚀
I've fixed it and it will be released in the next version (v1.4.0)