Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4002 add java21 jenkins support test java21 alldbs #4099

Closed

Conversation

psavidis
Copy link
Contributor

@psavidis psavidis commented Feb 13, 2024

DO NOT MERGE this PR.

This draft PR was opened to execute all stages of ci:all-dbs using JDK 21 and observe which pass.

Related-to: #4078

Context: Java 21 Lambdas have suffix `$$Lambda` instead of `$$Lambda$` for previous JDKs
Solution: Keep legacy behaviour conditionally & apply the new check for java versions > 21
This commit fixes the failing build on Jenkins. First tests that were failing the build were on the external client.
Other tests in the project suffered from the same issue, the replacement of `mockito-inline` dependency by `mockito-core`

- Update to Mockito 5.10.0
- After Mockito `5.3.0` release, `mockito-inline` is incorporated in `mockito-core`
- feel-scala is upgraded from 1.16.2 to 1.17.5
- The context of this change is use an artifact that supports building with JDK 21
@psavidis psavidis added the ci:all-db Runs the builds for all databases. label Feb 13, 2024
@psavidis psavidis self-assigned this Feb 13, 2024
@yanavasileva yanavasileva added the ci:no-build Prevents any CI stage from running. label Feb 13, 2024
@yanavasileva yanavasileva removed the ci:no-build Prevents any CI stage from running. label Feb 13, 2024
@psavidis
Copy link
Contributor Author

psavidis commented Feb 14, 2024

Update on Running JDK 21 with All Dbs check

  • All db executions failed with JDK 21 besides MariaDB 🙂
  • The failures are attributed to assertj:2.9.1 which uses shading and might be solved by assertj:3.7.0 . So it's probably safe to assume that the failures were not related to JDK 21
    • Most likely, they also fail already with JDK 17

@yanavasileva
Copy link
Member

yanavasileva commented Feb 15, 2024

With this PR we found that AssertJ 2.9.1 has bugs in the assertions that we use in the concurrent engine tests when JDK 21 is used. And updating to AssertJ (at least) 3.10.0 version will be an effort as we use removed API.

@psavidis
Copy link
Contributor Author

Update

Since there is high confidence on the compatibility of the JDBC drivers, this experimental PR can close.

@psavidis psavidis closed this Feb 15, 2024
@psavidis psavidis deleted the 4002-add-java21-jenkins-support_test-java21-alldbs branch February 15, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:all-db Runs the builds for all databases.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants