-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4002 add java21 jenkins support test java21 alldbs #4099
Closed
psavidis
wants to merge
9
commits into
master
from
4002-add-java21-jenkins-support_test-java21-alldbs
Closed
4002 add java21 jenkins support test java21 alldbs #4099
psavidis
wants to merge
9
commits into
master
from
4002-add-java21-jenkins-support_test-java21-alldbs
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: Java 21 Lambdas have suffix `$$Lambda` instead of `$$Lambda$` for previous JDKs Solution: Keep legacy behaviour conditionally & apply the new check for java versions > 21
This commit fixes the failing build on Jenkins. First tests that were failing the build were on the external client. Other tests in the project suffered from the same issue, the replacement of `mockito-inline` dependency by `mockito-core` - Update to Mockito 5.10.0 - After Mockito `5.3.0` release, `mockito-inline` is incorporated in `mockito-core`
- feel-scala is upgraded from 1.16.2 to 1.17.5 - The context of this change is use an artifact that supports building with JDK 21
This reverts commit 61fc355.
Update on Running JDK 21 with All Dbs check
|
8 tasks
With this PR we found that AssertJ 2.9.1 has bugs in the assertions that we use in the concurrent engine tests when JDK 21 is used. And updating to AssertJ (at least) 3.10.0 version will be an effort as we use removed API. |
UpdateSince there is high confidence on the compatibility of the JDBC drivers, this experimental PR can close. |
psavidis
deleted the
4002-add-java21-jenkins-support_test-java21-alldbs
branch
February 15, 2024 11:17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE this PR.
This draft PR was opened to execute all stages of
ci:all-dbs
usingJDK 21
and observe which pass.Related-to: #4078