Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(webapps): add translation handler #4352

Merged
merged 1 commit into from
Jun 20, 2024
Merged

fix(webapps): add translation handler #4352

merged 1 commit into from
Jun 20, 2024

Conversation

tasso94
Copy link
Member

@tasso94 tasso94 commented May 15, 2024

related to #4351

@tasso94 tasso94 added the ci:e2e Runs the frontend end-to-end tests. label May 15, 2024
@tasso94 tasso94 self-assigned this May 15, 2024
@tasso94 tasso94 mentioned this pull request May 15, 2024
Open
1 task
danielkelemen
danielkelemen approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@danielkelemen danielkelemen left a comment •
edited by tasso94

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good.

webapps/frontend/ui/tasklist/client/scripts/task/directives/cam-tasklist-task-meta.js Show resolved Hide resolved
@camunda camunda deleted a comment from danielkelemen May 17, 2024
@tasso94 tasso94 force-pushed the 4351-add-translation-handler branch from 61f6235 to 36c6526 Compare June 13, 2024 12:46
@tasso94
Copy link
Member Author

tasso94 commented Jun 14, 2024

Reverts fda59a6.

danielkelemen
danielkelemen approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member

@danielkelemen danielkelemen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good. Nice that you've found the cause of the endless loop.

@tasso94 tasso94 added the ci:no-build Prevents any CI stage from running. label Jun 18, 2024
@tasso94 tasso94 added ci:skipTests Skips tests execution in Assembly and Distro-ee stages. ci:e2e Runs the frontend end-to-end tests. ci:no-build Prevents any CI stage from running. and removed ci:no-build Prevents any CI stage from running. ci:e2e Runs the frontend end-to-end tests. ci:skipTests Skips tests execution in Assembly and Distro-ee stages. labels Jun 20, 2024
@tasso94 tasso94 force-pushed the 4351-add-translation-handler branch from b7639de to f09541a Compare June 20, 2024 10:15
@tasso94 tasso94 added ci:no-build Prevents any CI stage from running. and removed ci:no-build Prevents any CI stage from running. labels Jun 20, 2024
@tasso94
fix(webapps): add translation handler
0a662c6 
- Fix translation loading problem on the batch operation page.
- Execute new handler on all translation keys.
- Add search pill comparison operators as proper translate strings.
- Add null-conditional operator to avoid errors

related to #4351
@tasso94 tasso94 force-pushed the 4351-add-translation-handler branch from f09541a to 0a662c6 Compare June 20, 2024 12:22
@tasso94 tasso94 merged commit fba860b into master Jun 20, 2024
1 of 2 checks passed
@tasso94 tasso94 deleted the 4351-add-translation-handler branch June 20, 2024 12:23
@tasso94 tasso94 added bot:backport:7.20 Backports PR to maintenance branch 7.20. bot:backport:7.19 Backports PR to maintenance branch 7.19. bot:backport:7.21 Backports PR to maintenance branch 7.21. labels Jun 20, 2024
@tasso94
Copy link
Member Author

tasso94 commented Jun 20, 2024

/backport

@ap-development-workflow
Copy link

Successfully created backport PR for 7.20:

  • camunda/camunda-bpm-platform-maintenance#1243

@ap-development-workflow
Copy link

Backport failed for 7.19, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin 7.19
git worktree add -d .worktree/7.19-backport-4352 origin/7.19
cd .worktree/7.19-backport-4352
git switch --create 7.19-backport-4352
git cherry-pick -x fba860b82222c4263330f0425b773d80a7b2d7b9

@ap-development-workflow
Copy link

Successfully created backport PR for 7.21:

  • camunda/camunda-bpm-platform-maintenance#1244

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielkelemen danielkelemen danielkelemen approved these changes

Assignees

@tasso94 tasso94

Labels
bot:backport:7.19 Backports PR to maintenance branch 7.19. bot:backport:7.20 Backports PR to maintenance branch 7.20. bot:backport:7.21 Backports PR to maintenance branch 7.21. ci:e2e Runs the frontend end-to-end tests. ci:no-build Prevents any CI stage from running.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tasso94 @danielkelemen