Create separate gateway sub chart #145
Conversation
| @@ -0,0 +1,174 @@ | |||
| [](https://github.com/camunda-community-hub/community)[](https://github.com/Camunda-Community-Hub/community/blob/main/extension-lifecycle.md#incubating-)[](https://opensource.org/licenses/Apache-2.0) | |||
There was a problem hiding this comment.
This file will be completely replaced later, when I iterate over the readmes.
Template definitions for zeebe are already defined in zeebe subchart
|
Let me know if you need a reviewer additionally, but I assumed one was OK 👍 |
|
|
||
| {{- define "zeebe.labels.gateway" -}} | ||
| {{- template "zeebe.labels" . }} | ||
| app.kubernetes.io/component: gateway |
There was a problem hiding this comment.
| app.kubernetes.io/component: gateway | |
| app.kubernetes.io/component: zeebe-gateway |
Would this be more consistent?
There was a problem hiding this comment.
Not sure, for the brokers we have as label, component: broker 🤷 Would you prefer it ? :)
There was a problem hiding this comment.
I guess if we not look from a zeebe focused perspective but from a CCSM user perspective, I would expect prefixed labels with the component names, i.e. zeebe-, operate- etc.
So yes personally I would expect zeebe-gateway and zeebe-broker
There was a problem hiding this comment.
Makes sense to me let me do that as part of #147
|
Thanks @menski for the review 🙇 |
Create a separate sub chart for the standalone gateway.
zeebe-gateway)related #124