Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Common labels #147

Merged
merged 10 commits into from
Feb 3, 2022
Merged

Common labels #147

merged 10 commits into from
Feb 3, 2022

Conversation

Zelldon
Copy link
Member

@Zelldon Zelldon commented Feb 2, 2022 •
edited

Follows https://helm.sh/docs/chart_best_practices/labels/#standard-labels to set up common labels

  • create a common labels template
  • Use template in all sub charts and resourcess

Example:

 labels: 
    app: camunda-cloud-self-managed
    app.kubernetes.io/name: zeebe
    helm.sh/chart: zeebe-0.0.1
    app.kubernetes.io/instance: test-release
    app.kubernetes.io/managed-by: Helm
    app.kubernetes.io/version: 1.3.1
    app.kubernetes.io/part-of: camunda-cloud-self-managed
    app.kubernetes.io/component: zeebe-broker

closes #131
related to #124

@Zelldon
refactor: iterate over helper templates
f1b9c03 
 * remove unused template definitions
 * create common template for labels and include it in subchart label templates
@Zelldon
refactor: improve ccsm labels
170c79f 
 * Remove quotes
* include global labels
@Zelldon
feat: use zeebe common labels on all resources
4cf7024
@Zelldon
refactor: move include in same line
5ef3d09 
With using nindent we don't need to add a separate newline and it can be added in the same line as the key: labels:
@Zelldon
fix: use labels everywhere in tasklist
953bca3
@Zelldon
refactor: use common labels in operate
0a0626b
@Zelldon
fix: set correct selector
9dbf4a9
This was referenced Feb 2, 2022
Closed
Merged
Zelldon
Zelldon commented Feb 3, 2022
View reviewed changes
charts/ccsm-helm/charts/zeebe-gateway/templates/_helpers.tpl Outdated
*/}}
{{- define "zeebe.labels.gateway" -}}
{{- template "ccsm.labels" . }}
app.kubernetes.io/component: gateway
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #145 (comment)

@Zelldon
Merge branch 'main' into zell-common-labels
3d67b03
@Zelldon
Merge branch 'main' into zell-common-labels
222c075
@Zelldon
refactor: use zeebe- prefix
f3bf3f1 
To make more cleare where the gateway belongs to we add the zeebe- prefix to the broker and gateway component
@Zelldon Zelldon marked this pull request as ready for review February 3, 2022 06:22
@Zelldon
Copy link
Member Author

Zelldon commented Feb 3, 2022

I would like to request a review from you @Sijoma but seems to be not possible 🤷 Maybe you can still take a look, let me know if you have no time. I thought this would be something which is in your interest. Maybe we can have similar labels in the controller at some point.

Sijoma
Sijoma approved these changes Feb 3, 2022
View reviewed changes
Copy link

@Sijoma Sijoma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a nice refactor!

@Zelldon
Copy link
Member Author

Zelldon commented Feb 3, 2022

Thanks for the review @Sijoma 🙇

@Zelldon Zelldon merged commit 67ec0e1 into main Feb 3, 2022
@Zelldon Zelldon deleted the zell-common-labels branch February 3, 2022 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sijoma Sijoma Sijoma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use standardized and recommended labels in CCSM Chart
2 participants
@Zelldon @Sijoma