Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch variables by name when evaluating a decision #8092

Open
saig0 opened this issue Oct 28, 2021 · 2 comments
Open

Fetch variables by name when evaluating a decision #8092

saig0 opened this issue Oct 28, 2021 · 2 comments
Labels
area/performance Marks an issue as performance related component/engine component/zeebe Related to the Zeebe component/team kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. scope/broker Marks an issue or PR to appear in the broker section of the changelog

Comments

@saig0
Copy link
Member

saig0 commented Oct 28, 2021

Description

Currently, the DMN engine doesn't provide a way to fetch the variables lazily. Instead, all variables must be provided when evaluating the decision.

When the DMN engine supports the lazy fetching of variables by their name then we should use it in the DMN module to avoid unnecessary database access and variable transformations. This should look similar to the expression language module.

blocked by #8082

requires camunda/dmn-scala#106

@saig0 saig0 added kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. scope/broker Marks an issue or PR to appear in the broker section of the changelog area/performance Marks an issue as performance related labels Oct 28, 2021
@saig0 saig0 added this to the Evaluate DMN decisions milestone Oct 28, 2021
@falko
Copy link
Member

falko commented Apr 14, 2023

Could such a lazy fetching of variable allow for an extension point to load data from outside the engine, e.g. through a job that a worker or connector could implement? I'm asking because this is in discussion for DMN 1.6

@saig0
Copy link
Member Author

saig0 commented Apr 19, 2023

Could such a lazy fetching of variable allow for an extension point to load data from outside the engine, e.g. through a job that a worker or connector could implement?

@falko no. This is not the intention of the issue. It's just about the internal integration of the DMN engine inside Zeebe.

We have the same concept for the FEEL engine. It accesses the Zeebe data and loads the required data. But we don't use the same concept for the DMN engine yet.

@romansmirnov romansmirnov added the component/zeebe Related to the Zeebe component/team label Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/performance Marks an issue as performance related component/engine component/zeebe Related to the Zeebe component/team kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. scope/broker Marks an issue or PR to appear in the broker section of the changelog
Projects
None yet
Development

No branches or pull requests

5 participants