-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flaky EmbeddedSubProcessTest
#12697
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test was flaky because it could occur that the messages got published before the subscription were opened. As the messages have no TTL this means they were not getting correlated, as expected.
remcowesterhoud
added
backport stable/8.0
backport stable/8.2
Backport a pull request to 8.2.x
labels
May 8, 2023
koevskinikola
approved these changes
May 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
bors merge
Build succeeded: |
ghost
deleted the
11844_flaky_test
branch
May 9, 2023 07:09
Backport failed for Please cherry-pick the changes locally. git fetch origin stable/8.0
git worktree add -d .worktree/backport-12697-to-stable/8.0 origin/stable/8.0
cd .worktree/backport-12697-to-stable/8.0
git checkout -b backport-12697-to-stable/8.0
ancref=$(git merge-base 46cd2fae7fb0b770a5be6f9204b300891ee3077c cb26d2c2eeb684bfe53dfd4f1f9b513f289fbea8)
git cherry-pick -x $ancref..cb26d2c2eeb684bfe53dfd4f1f9b513f289fbea8 |
Successfully created backport PR for |
Successfully created backport PR for |
ghost
pushed a commit
that referenced
this pull request
May 9, 2023
ghost
pushed a commit
that referenced
this pull request
May 9, 2023
ghost
pushed a commit
that referenced
this pull request
May 10, 2023
lenaschoenburg
added
the
version:8.2.5
Marks an issue as being completely or in parts released in 8.2.5
label
May 16, 2023
lenaschoenburg
added
version:8.1.13
Marks an issue as being completely or in parts released in 8.1.13
release/8.0.16
labels
Jun 7, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 9, 2024
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport stable/8.2
Backport a pull request to 8.2.x
version:8.1.13
Marks an issue as being completely or in parts released in 8.1.13
version:8.2.5
Marks an issue as being completely or in parts released in 8.2.5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The test was flaky because it could occur that the messages got published before the subscription were opened. As the messages have no TTL this means they were not getting correlated, as expected.
Log of a failing run:
The test isn't really flaky on 8.2+ anymore. This is a result of batch processing that was introduced recently. However, I believe it's still good to fix it on all versions and keep the test aligned across versions.
Related issues
closes #11844
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
backport stable/1.3
) to the PR, in case that fails you need to create backports manually.Testing:
Documentation:
Other teams:
If the change impacts another team an issue has been created for this team, explaining what they need to do to support this change.
Please refer to our review guidelines.