Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure correct webhook behavior on correlation failures #2596

Closed
chillleader opened this issue May 21, 2024 · 1 comment · Fixed by #2776
Closed

Ensure correct webhook behavior on correlation failures #2596

chillleader opened this issue May 21, 2024 · 1 comment · Fixed by #2776
Assignees
Labels
component:qa Task containing all details related to QA kind:task Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc.

Comments

@chillleader
Copy link
Member

What should we do?

  • Define how the webhook connector should behave in case of activation condition mismatch and other errors
  • Decide whether we need to make this behavior configurable using the acknowledgement config options
  • Make sure the webhook behavior is aligned with our expectations

Why should we do it?

To ensure no surprises for our users, the webhook connector should handle errors in a predictable manner.

This is part of the following epic: https://github.com/camunda/product-hub/issues/2157

@chillleader chillleader added the kind:task Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. label May 21, 2024
@chillleader chillleader self-assigned this May 21, 2024
@chillleader
Copy link
Member Author

As discussed with the team, we should:

  • "Flip" the switch to ensure backward compatibility (i.e. messages are acknowledged by default if they don't match the activation condition).
  • Enable this feature for the webhook connector

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:qa Task containing all details related to QA kind:task Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant