-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extra escape backslash added to AWS Eventbridge Secret #2659
Comments
@upgradingdave I wasn't able to reproduce the issue with 8.5 - although in Operate you will see the backslash with an escape character (that's a limitation in JSON that those have to be escaped), in the connector itself, the backslash is unescaped and passed to AWS in its original format. Is it possible that the authentication issue was caused by something different? On the other hand, I found that it's not possible to use unescaped backslashes inside connector secrets. Because of how the secret replacement currently works (we serialize variables to string and replace secret syntax in that string), substituting a value that contains an unescaped backslash results in invalid json, and the value cannot be deserialized again. As a workaround, such backslash characters need to be escaped in connector secrets. FYI @sbuettner |
@chillleader I think we can close this one. WDYT? |
Yep, let's close it for now. @upgradingdave please feel free to reopen if you run into a similar issue again |
Yes sounds good, feel free to close. For the record: the root cause of the authentication issue for this case turned out to be something different than backslash interpretation. The customer did not realize that inbound connector secrets are only evaluated when process definitions are deployed (The secrets are not evaluated every time a inbound connector is called). When the customer redeployed the inbound connector with a properly escaped password, that fixed the issue. |
Describe the Bug
An extra backslash character (
\
) is added to secrets when the secret value also contains a\+
character sequence.This is a problem because AWS will generate secrets and sometimes those secrets contain backslashes
\
. If an extra backslash is added, this breaks the authentication.Steps to Reproduce
123\+45
into theSecret Key
field of the Credentials Authentication Sectionauthentication
instance variable for the task has an extra backslash character added:\
.Expected Behavior
The secret value should be sent to AWS exactly how it's entered into Web Modeler. No extra backslashes should be added.
Environment
The text was updated successfully, but these errors were encountered: