Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sns): migrate to element template generator #2266

Conversation

igpetrov
Copy link
Contributor

chore(sns): migrate to element template generator

@igpetrov igpetrov self-assigned this Mar 27, 2024
@igpetrov igpetrov requested a review from a team as a code owner March 27, 2024 20:22
@igpetrov igpetrov marked this pull request as draft March 28, 2024 12:03
@igpetrov igpetrov force-pushed the 707-migrate-sns-inbound-connector-to-element-template-generator branch 3 times, most recently from 311041a to 53b8ea7 Compare March 29, 2024 16:09
@igpetrov igpetrov marked this pull request as ready for review March 29, 2024 16:11
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider FeelMode values #2279 (comment)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added those explicitly

chillleader
chillleader previously approved these changes Apr 2, 2024
Oleksiivanov
Oleksiivanov previously approved these changes Apr 2, 2024
@igpetrov igpetrov dismissed stale reviews from Oleksiivanov and chillleader via c581554 April 2, 2024 10:30
@igpetrov igpetrov force-pushed the 707-migrate-sns-inbound-connector-to-element-template-generator branch from 53b8ea7 to c581554 Compare April 2, 2024 10:30
@igpetrov igpetrov force-pushed the 707-migrate-sns-inbound-connector-to-element-template-generator branch from c581554 to a66a653 Compare April 2, 2024 13:17
@igpetrov igpetrov force-pushed the 707-migrate-sns-inbound-connector-to-element-template-generator branch from a66a653 to 9bd5bd5 Compare April 2, 2024 14:46
@igpetrov igpetrov added this pull request to the merge queue Apr 2, 2024
Merged via the queue into main with commit 3ae7d9e Apr 2, 2024
4 checks passed
@igpetrov igpetrov deleted the 707-migrate-sns-inbound-connector-to-element-template-generator branch April 2, 2024 16:16
github-merge-queue bot pushed a commit that referenced this pull request Apr 4, 2024
* feat(rabbitmq): Add to template generator

* feat(rabbitmq): Move pattern constraint in the right place

* feat(rabbitmq): Refactor RabbitMq E2E tests

* feat(rabbitmq): Add missing annotations to some fields

* feat(rabbitmq): Refactor existing RabbitMq tests

* Outbound GitLab Connector enhancements (#2214)

* feat(gitlab): list repository branches

* feat(gitlab): create repository branch

* feat(gitlab): create repository file

* feat(gitlab): create merge request

* chore(gitlab): review feedback

* fix(rest): more meaningful error message on invalid host (#2245)

* fix(deps): update aws-java-sdk monorepo to v1.12.688 (#2253)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency com.google.apis:google-api-services-sheets to v4-rev20240319-2.0.0 (#2254)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(sendgrid): capitalize sender group name in the template (#2252)

* chore(deps): update dependency org.cyclonedx:cyclonedx-maven-plugin to v2.8.0 (#2256)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency com.microsoft.graph:microsoft-graph to v6.5.0 (#2258)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* feat(rabbitmq): Add RabbitMq InbC E2E tests

* feat(rabbitmq): Add URI Pattern validation

* feat(rabbitmq): Add missing $ to the URI Pattern

* feat(rabbitmq): Revert BpmnFile debug change

* feat(rabbitmq): Use the existing secrets Pattern for consistency

* bug(inboundc): Fix potential infinite retries on message idempotency check fails (#2281)

* ci: fix integration test GHA (#2274)

* fix(generator): FEEL mode = disabled not applied in some cases (#2286)

* feat(template generator): set default value feel = false for all inbound connectors (#2264)

* fix(generator): standardize line endings in generated element templates (#2288)

* chore(sns): migrate to element template generator (#2266)

* chore(slack): migrate slack inbound to generator (#2279)

* chore(inbound,sqs): move to generator (#2249)

* chore(inbound,sqs): move to generator

* fix(sqs): fixed correct template overrides

Co-authored-by: Oleksii Ivanov <108869886+Oleksiivanov@users.noreply.github.com>

* chore(inbound,sqs): corrected generator props

---------

Co-authored-by: Oleksii Ivanov <108869886+Oleksiivanov@users.noreply.github.com>

* feat(rabbitmq): Rebase main + re generate all templates

---------

Co-authored-by: Wolfgang Amann <8766375+wollefitz@users.noreply.github.com>
Co-authored-by: Igor Petrov <108870003+igpetrov@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Pavel Kotelevsky <38818382+chillleader@users.noreply.github.com>
Co-authored-by: Oleksii Ivanov <108869886+Oleksiivanov@users.noreply.github.com>
Co-authored-by: Mark Farkas <119574841+markfarkas-camunda@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants