fix(generator): standardize line endings in generated element templates #2288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markfarkas-camunda
deleted the
element-template-generator-line-ending-fix-for-windows
branch
johnBgood
pushed a commit
that referenced
this pull request
Apr 3, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 4, 2024
* feat(rabbitmq): Add to template generator * feat(rabbitmq): Move pattern constraint in the right place * feat(rabbitmq): Refactor RabbitMq E2E tests * feat(rabbitmq): Add missing annotations to some fields * feat(rabbitmq): Refactor existing RabbitMq tests * Outbound GitLab Connector enhancements (#2214) * feat(gitlab): list repository branches * feat(gitlab): create repository branch * feat(gitlab): create repository file * feat(gitlab): create merge request * chore(gitlab): review feedback * fix(rest): more meaningful error message on invalid host (#2245) * fix(deps): update aws-java-sdk monorepo to v1.12.688 (#2253) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency com.google.apis:google-api-services-sheets to v4-rev20240319-2.0.0 (#2254) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(sendgrid): capitalize sender group name in the template (#2252) * chore(deps): update dependency org.cyclonedx:cyclonedx-maven-plugin to v2.8.0 (#2256) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency com.microsoft.graph:microsoft-graph to v6.5.0 (#2258) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * feat(rabbitmq): Add RabbitMq InbC E2E tests * feat(rabbitmq): Add URI Pattern validation * feat(rabbitmq): Add missing $ to the URI Pattern * feat(rabbitmq): Revert BpmnFile debug change * feat(rabbitmq): Use the existing secrets Pattern for consistency * bug(inboundc): Fix potential infinite retries on message idempotency check fails (#2281) * ci: fix integration test GHA (#2274) * fix(generator): FEEL mode = disabled not applied in some cases (#2286) * feat(template generator): set default value feel = false for all inbound connectors (#2264) * fix(generator): standardize line endings in generated element templates (#2288) * chore(sns): migrate to element template generator (#2266) * chore(slack): migrate slack inbound to generator (#2279) * chore(inbound,sqs): move to generator (#2249) * chore(inbound,sqs): move to generator * fix(sqs): fixed correct template overrides Co-authored-by: Oleksii Ivanov <108869886+Oleksiivanov@users.noreply.github.com> * chore(inbound,sqs): corrected generator props --------- Co-authored-by: Oleksii Ivanov <108869886+Oleksiivanov@users.noreply.github.com> * feat(rabbitmq): Rebase main + re generate all templates --------- Co-authored-by: Wolfgang Amann <8766375+wollefitz@users.noreply.github.com> Co-authored-by: Igor Petrov <108870003+igpetrov@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Pavel Kotelevsky <38818382+chillleader@users.noreply.github.com> Co-authored-by: Oleksii Ivanov <108869886+Oleksiivanov@users.noreply.github.com> Co-authored-by: Mark Farkas <119574841+markfarkas-camunda@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On windows machines the generator used CRLF line endings instead of LF, so the generated files were all different. In this PR we specify the line endings explicitly, so it will be the same on Windows as well.