Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove version tag in submodules #9079

Closed
npepinpe opened this issue Apr 8, 2022 · 0 comments · Fixed by #9098
Closed

Remove version tag in submodules #9079

npepinpe opened this issue Apr 8, 2022 · 0 comments · Fixed by #9098
Assignees
@pihme
Labels
area/maintainability Marks an issue as improving the maintainability of the project kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. version:8.1.0-alpha1 Marks an issue as being completely or in parts released in 8.1.0-alpha1 version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0

Comments

@npepinpe
Copy link
Member

npepinpe commented Apr 8, 2022

Description

Maven child modules will inherit the version from their parent. To ease maintenance, there's no reason to have the version tag in the child modules as well as long as they inherit it from their parent.
@npepinpe npepinpe added the kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. label Apr 8, 2022
@npepinpe npepinpe self-assigned this Apr 8, 2022
@npepinpe npepinpe removed their assignment Apr 11, 2022
@pihme pihme self-assigned this Apr 11, 2022
@pihme pihme mentioned this issue Apr 11, 2022
Merged
10 tasks
@npepinpe npepinpe added area/reliability Marks an issue as related to improving the reliability of our software (i.e. it behaves as expected) area/maintainability Marks an issue as improving the maintainability of the project and removed kind/toil area/reliability Marks an issue as related to improving the reliability of our software (i.e. it behaves as expected) labels Apr 11, 2022
ghost pushed a commit that referenced this issue Apr 12, 2022
@pihme
merge: #9098
16d0e68 
9098: Remove redundant version statements r=npepinpe a=pihme

## Description

Removes version statements if the value is inherited

## Related issues

closes #9079



Co-authored-by: pihme <pihme@users.noreply.github.com>
@ghost ghost closed this as completed in #9098 Apr 12, 2022
@deepthidevaki deepthidevaki added the version:8.1.0-alpha1 Marks an issue as being completely or in parts released in 8.1.0-alpha1 label May 3, 2022
@Zelldon Zelldon added the version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0 label Oct 4, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pihme pihme

Labels
area/maintainability Marks an issue as improving the maintainability of the project kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. version:8.1.0-alpha1 Marks an issue as being completely or in parts released in 8.1.0-alpha1 version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove redundant version statements camunda/camunda
4 participants
@npepinpe @deepthidevaki @Zelldon @pihme