Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect creation_mode used for process_instance_creations_total metric #9653

Closed
korthout opened this issue Jun 29, 2022 · 1 comment · Fixed by #9654
Closed

Incorrect creation_mode used for process_instance_creations_total metric #9653

korthout opened this issue Jun 29, 2022 · 1 comment · Fixed by #9654
Assignees
@korthout
Labels
area/observability Marks an issue as observability related kind/bug Categorizes an issue or PR as a bug version:8.1.0-alpha3 Marks an issue as being completely or in parts released in 8.1.0-alpha3 version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0

Comments

@korthout
Copy link
Member

Describe the bug

The process_instance_creations_total metric keeps track of the created process instances. It is registered with a creation_mode label to distinguish CREATION_AT_DEFAULT_START_EVENT from CREATION_AT_GIVEN_ELEMENT. However, when process instances are created at the default start event the metric with CREATION_AT_GIVEN_ELEMENT is incremented, and vice-versa for creations at a given element.

To Reproduce

  • run the latest Zeebe version with Prometheus.
  • create a process instance without start instructions
  • check the results for sum(rate(zeebe_process_instance_creations_total[1m])) by (creation_mode)

Expected behavior

The correct metrics should be incremented.

Environment:

  • OS: ...
  • Zeebe Version: medic-cw-25 and onwards
  • Configuration: ...
@korthout korthout added kind/bug Categorizes an issue or PR as a bug area/observability Marks an issue as observability related team/process-automation labels Jun 29, 2022
@korthout korthout self-assigned this Jun 29, 2022
@korthout
Copy link
Member Author

I believe this was mistakenly introduced here. Should be easy to fix.

@korthout korthout mentioned this issue Jun 29, 2022
Merged
10 tasks
ghost pushed a commit that referenced this issue Jun 30, 2022
@korthout
merge: #9654
ad83fae 
9654: Fix incorrect creation_mode usage in process instance creations metric r=saig0 a=korthout

## Description

<!-- Please explain the changes you made here. -->
A refactoring in an earlier PR accidentally flipped some boolean logic which resulted in the wrong creation_mode being used in the `process_instance_creations_total` metric. This PR re-flips this logic.

## Related issues

<!-- Which issues are closed by this PR or are related -->

closes #9653



Co-authored-by: Nico Korthout <nico.korthout@camunda.com>
@ghost ghost closed this as completed in 10e2168 Jun 30, 2022
@lenaschoenburg lenaschoenburg added the version:8.1.0-alpha3 Marks an issue as being completely or in parts released in 8.1.0-alpha3 label Jul 5, 2022
@Zelldon Zelldon added the version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0 label Oct 4, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@korthout korthout

Labels
area/observability Marks an issue as observability related kind/bug Categorizes an issue or PR as a bug version:8.1.0-alpha3 Marks an issue as being completely or in parts released in 8.1.0-alpha3 version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix incorrect creation_mode usage in process instance creations metric camunda/camunda
3 participants
@lenaschoenburg @Zelldon @korthout