Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify backup and restore in a multipartition cluster #10516

Merged
1 commit merged into from
Sep 30, 2022
Merged

Verify backup and restore in a multipartition cluster #10516

1 commit merged into from
Sep 30, 2022

Conversation

deepthidevaki
Copy link
Contributor

Description

Added test to verify

  • Backups are triggered via inter partition messages
  • A cluster with multiple partitions can restore from a backup

Related issues

related #10387

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. backport stable/1.3) to the PR, in case that fails you need to create backports manually.

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually
  • The change has been verified by a QA run
  • The impact of the changes is verified by a benchmark

Documentation:

  • The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
  • New content is added to the release announcement
  • If the PR changes how BPMN processes are validated (e.g. support new BPMN element) then the Camunda modeling team should be informed to adjust the BPMN linting.

Please refer to our review guidelines.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 27, 2022 •
edited
Loading

Test Results

   935 files  +    1     935 suites  +1   2h 11m 13s ⏱️ + 3m 14s
7 583 tests +216  7 577 ✔️ +216  6 💤 ±0  0 ❌ ±0 
7 773 runs  +216  7 765 ✔️ +216  8 💤 ±0  0 ❌ ±0 

Results for commit 5ef5b73. ± Comparison against base commit f23b81f.

♻️ This comment has been updated with latest results.

@deepthidevaki deepthidevaki force-pushed the dd-10387-multi-partition-integration-test branch from 3335d9f to 72e2990 Compare September 27, 2022 11:21
lenaschoenburg
lenaschoenburg requested changes Sep 29, 2022
View reviewed changes
Copy link
Member

@lenaschoenburg lenaschoenburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @deepthidevaki, this looks mostly good but I think the shouldRestoreOnAllPartitions test is not correct, please take a look.

qa/integration-tests/src/test/java/io/camunda/zeebe/it/backup/BackupMultiPartitionTest.java Outdated Show resolved Hide resolved
@deepthidevaki
Copy link
Contributor Author

Marking this PR for backporting to release branch. This is only test, but would be good to have it in the stable branch after release to help backport future bugs.

@deepthidevaki deepthidevaki force-pushed the dd-10387-multi-partition-integration-test branch from aeca470 to 5ef5b73 Compare September 30, 2022 07:03
@deepthidevaki
Copy link
Contributor Author

bors merge

@ghost
Copy link

ghost commented Sep 30, 2022

Build succeeded:

@ghost ghost merged commit a6a61b9 into main Sep 30, 2022
@ghost ghost deleted the dd-10387-multi-partition-integration-test branch September 30, 2022 07:36
@backport-action backport-action mentioned this pull request Sep 30, 2022
Merged
@backport-action
Copy link
Collaborator

Successfully created backport PR #10579 for release-8.1.0.

ghost pushed a commit that referenced this pull request Sep 30, 2022
@deepthidevaki
merge: #10579
0b2d0a8 
10579: [Backport release-8.1.0] Verify backup and restore in a multipartition cluster r=deepthidevaki a=backport-action

# Description
Backport of #10516 to `release-8.1.0`.

relates to #10387

Co-authored-by: Deepthi Devaki Akkoorath <deepthidevaki@gmail.com>
@Zelldon Zelldon added the version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0 label Oct 4, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lenaschoenburg lenaschoenburg lenaschoenburg approved these changes

Assignees
No one assigned
Labels
version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@deepthidevaki @backport-action @lenaschoenburg @Zelldon