test(qa-client): use SocketUtil to get unused free port for connect failure test #10517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
megglos
force-pushed
the
meg-10502-client-exception-flaky-fix
branch
from
e1d84e8
to
f8c90ac
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
qa/integration-tests/src/test/java/io/camunda/zeebe/it/client/ClientExceptionHandlingTest.java
Fixed
Show fixed
Hide fixed
megglos
force-pushed
the
meg-10502-client-exception-flaky-fix
branch
from
f8c90ac
to
e5e858b
Compare
…ailure test Previously a fixed port was used that could collide with actually used ports from other forks. Given the default testMavenId of 0, ports assigned by the SocketUtil start at 1025 and can collide with the 1234 port always used here, causing different than expected connect behaviour.
megglos
force-pushed
the
meg-10502-client-exception-flaky-fix
branch
from
e5e858b
to
a63b448
Compare
megglos
changed the title
|
the warnings from CodeQL are actually not related to my changes 🤷 |
|
bors merge |
ghost
pushed a commit
that referenced
this pull request
Sep 27, 2022
10517: test(qa-client): use SocketUtil to get unused free port for connect failure test r=megglos a=megglos Previously a fixed port was used that could collide with actually used ports from other forks. Given the default testMavenId of 0, ports assigned by the SocketUtil start at 1025 and can collide with the 1234 port always used here, causing different than expected connect behaviour. ## Description <!-- Please explain the changes you made here. --> ## Related issues closes #10502 Co-authored-by: Meggle (Sebastian Bathke) <sebastian.bathke@camunda.com>
|
Build failed: |
|
bors retry |
|
Build succeeded: |
ghost
merged commit 
|
Successfully created backport PR #10523 for |
|
Successfully created backport PR #10524 for |
Zelldon
added
the
version:8.1.0
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously a fixed port was used that could collide with actually used ports from other forks. Given the default testMavenId of 0, ports assigned by the SocketUtil start at 1025 and can collide with the 1234 port always used here, causing different than expected connect behaviour.
Description
Related issues
closes #10502
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
backport stable/1.3) to the PR, in case that fails you need to create backports manually.Testing:
Documentation:
Please refer to our review guidelines.