-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy process with data object and data store #10845
Conversation
...test/java/io/camunda/zeebe/engine/processing/deployment/model/validation/DataObjectTest.java
Fixed
Show fixed
Hide fixed
Test Results 782 files - 167 782 suites - 167 1h 32m 59s ⏱️ - 7m 43s For more details on these failures, see this check. Results for commit 2f0278a. ± Comparison against base commit dfae49f. ♻️ This comment has been updated with latest results. |
...test/java/io/camunda/zeebe/engine/processing/deployment/model/validation/DataObjectTest.java
Fixed
Show fixed
Hide fixed
… objects or data stores
2a3c3cb
to
bbb1c89
Compare
@skayliu thank you for your contribution. 🎉 We'll have a look at your PR in the next few days. 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @skayliu, I added some review hints to the PR.
👍 In general, the fix looks good. I especially liked the additional test coverage.
bpmn-model/src/main/java/io/camunda/zeebe/model/bpmn/validation/zeebe/FlowElementValidator.java
Outdated
Show resolved
Hide resolved
...test/java/io/camunda/zeebe/engine/processing/deployment/model/validation/DataObjectTest.java
Outdated
Show resolved
Hide resolved
...test/java/io/camunda/zeebe/engine/processing/deployment/model/validation/DataObjectTest.java
Outdated
Show resolved
Hide resolved
protocol/src/main/java/io/camunda/zeebe/protocol/record/value/BpmnElementType.java
Outdated
Show resolved
Hide resolved
...eebe/engine/processing/deployment/model/transformer/FlowElementInstantiationTransformer.java
Outdated
Show resolved
Hide resolved
Hi @koevskinikola. I've fixed all review comments. Please check this out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now. Thanks for the contribution! 🚀
bors merge
🔒 Permission denied Existing reviewers: click here to make koevskinikola a reviewer |
bors merge |
Build succeeded: |
/backport |
Successfully created backport PR #10916 for |
Successfully created backport PR #10917 for |
Description
Support deploy and execute process with data object and data store
Related issues
closes #8230
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
backport stable/1.3
) to the PR, in case that fails you need to create backports manually.Testing:
Documentation:
Please refer to our review guidelines.