Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy process with data object and data store #10845

Merged
2 commits merged into from
Nov 4, 2022
Merged

Deploy process with data object and data store #10845

2 commits merged into from
Nov 4, 2022

Conversation

skayliu
Copy link
Contributor

@skayliu skayliu commented Oct 28, 2022 •
edited
Loading

Description

Support deploy and execute process with data object and data store

Related issues

closes #8230

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. backport stable/1.3) to the PR, in case that fails you need to create backports manually.

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually
  • The change has been verified by a QA run
  • The impact of the changes is verified by a benchmark

Documentation:

  • The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
  • New content is added to the release announcement
  • If the PR changes how BPMN processes are validated (e.g. support new BPMN element) then the Camunda modeling team should be informed to adjust the BPMN linting.

Please refer to our review guidelines.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 28, 2022 •
edited
Loading

Test Results

   782 files   -    167     782 suites   - 167   1h 32m 59s ⏱️ - 7m 43s
6 073 tests  - 1 629  6 065 ✔️  - 1 630  7 💤 ±0  1 ❌ +1 
6 236 runs   - 1 664  6 226 ✔️  - 1 665  9 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 2f0278a. ± Comparison against base commit dfae49f.

♻️ This comment has been updated with latest results.

@skayliu skayliu force-pushed the 8230-data-object-and-data-store branch from 2a3c3cb to bbb1c89 Compare October 28, 2022 10:11
@skayliu
Copy link
Contributor Author

skayliu commented Nov 1, 2022

Hi, @saig0, @korthout. Please take a moment to review this feature when you have time. Thanks. ❤️

@saig0
Copy link
Member

saig0 commented Nov 1, 2022

@skayliu thank you for your contribution. 🎉 We'll have a look at your PR in the next few days. 👀

@koevskinikola koevskinikola self-assigned this Nov 1, 2022
@koevskinikola koevskinikola self-requested a review November 1, 2022 10:49
@saig0 saig0 added the hacktoberfest-accepted Marks an issue as having been accepted as a Hacktoberfest contribution label Nov 1, 2022
@skayliu skayliu changed the title feat(engine): deploy process with data object and data store Deploy process with data object and data store Nov 2, 2022
koevskinikola
koevskinikola requested changes Nov 3, 2022
View reviewed changes
Copy link
Member

@koevskinikola koevskinikola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @skayliu, I added some review hints to the PR.

👍 In general, the fix looks good. I especially liked the additional test coverage.

bpmn-model/src/main/java/io/camunda/zeebe/model/bpmn/validation/zeebe/FlowElementValidator.java Outdated Show resolved Hide resolved
...test/java/io/camunda/zeebe/engine/processing/deployment/model/validation/DataObjectTest.java Outdated Show resolved Hide resolved
...test/java/io/camunda/zeebe/engine/processing/deployment/model/validation/DataObjectTest.java Outdated Show resolved Hide resolved
protocol/src/main/java/io/camunda/zeebe/protocol/record/value/BpmnElementType.java Outdated Show resolved Hide resolved
...eebe/engine/processing/deployment/model/transformer/FlowElementInstantiationTransformer.java Outdated Show resolved Hide resolved
@skayliu
Copy link
Contributor Author

skayliu commented Nov 3, 2022

Hi @koevskinikola. I've fixed all review comments. Please check this out.

koevskinikola
koevskinikola approved these changes Nov 4, 2022
View reviewed changes
Copy link
Member

@koevskinikola koevskinikola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. Thanks for the contribution! 🚀

bors merge

@ghost
Copy link

ghost commented Nov 4, 2022

🔒 Permission denied

Existing reviewers: click here to make koevskinikola a reviewer

@menski
Copy link
Contributor

menski commented Nov 4, 2022

bors merge

@ghost
Copy link

ghost commented Nov 4, 2022

Build succeeded:

@ghost ghost merged commit 9767955 into camunda:main Nov 4, 2022
@skayliu skayliu deleted the 8230-data-object-and-data-store branch November 4, 2022 09:06
@remcowesterhoud
Copy link
Contributor

/backport

@backport-action
Copy link
Collaborator

Successfully created backport PR #10916 for stable/8.0.

This was referenced Nov 4, 2022
Merged
Merged
@backport-action
Copy link
Collaborator

Successfully created backport PR #10917 for stable/8.1.

ghost pushed a commit that referenced this pull request Nov 4, 2022
@skayliu
merge: #10916
825b97b 
10916: [Backport stable/8.0] Deploy process with data object and data store r=koevskinikola a=backport-action

# Description
Backport of #10845 to `stable/8.0`.

relates to #8230

Co-authored-by: skayliu <skay463@163.com>
ghost pushed a commit that referenced this pull request Nov 4, 2022
@skayliu
merge: #10917
56fbf7b 
10917: [Backport stable/8.1] Deploy process with data object and data store r=koevskinikola a=backport-action

# Description
Backport of #10845 to `stable/8.1`.

relates to #8230

Co-authored-by: skayliu <skay463@163.com>
@remcowesterhoud remcowesterhoud added the version:8.1.4 Marks an issue as being completely or in parts released in 8.1.4 label Nov 22, 2022
@skayliu skayliu mentioned this pull request Dec 3, 2022
Closed
@korthout korthout mentioned this pull request Aug 14, 2024
Open
9 tasks
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koevskinikola koevskinikola koevskinikola approved these changes

Assignees

@koevskinikola koevskinikola

Labels
hacktoberfest-accepted Marks an issue as having been accepted as a Hacktoberfest contribution version:8.1.4 Marks an issue as being completely or in parts released in 8.1.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BPMN deployment fails due to Data Object
6 participants
@skayliu @saig0 @menski @remcowesterhoud @backport-action @koevskinikola