feat: log details of cancelled transitions #11069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When one transition cancels another, we were only logging a generic "cancel" message. This was lacking context, specifically which transition causes a cancellation. Here we add a `toString` implementation for `PartitionTransitionProcess` that shows term, role, status and the remaining steps. This is used in a new log statement that should provide us with the necessary context.
deepthidevaki
approved these changes
Nov 22, 2022
| @@ -109,6 +109,9 @@ private void enqueueNextTransition( | |||
| ongoingTransitionFuture = currentTransitionFuture; | |||
|
|
|||
| final var ongoingTransition = currentTransition; | |||
|
|
|||
| LOG.info( | |||
There was a problem hiding this comment.
❌ This will be logged everytime there is transition. Previous transition needs to be cancelled only if it was not completed. So you should log only if !ongoingTransition.isCompleted()
There was a problem hiding this comment.
Oh nice catch! I didn't realize that currentTransition is not cleared when it is completed 👍
There was a problem hiding this comment.
May be it is better to clear currentTransition after it is completed. Not sure if it causes other issues.
There was a problem hiding this comment.
It's tricky to do this correctly. By the time a transition finishes, the currentTransition might be a newer transition so we shouldn't just set it to null.
There was a problem hiding this comment.
Yeah, I'd rather not touch that right now so I only added a check so that we only log if the "current" transition is not completed, like you suggested.
|
bors r+ |
ghost
pushed a commit
that referenced
this pull request
Nov 22, 2022
11069: feat: log details of cancelled transitions r=oleschoenburg a=oleschoenburg When one transition cancels another, we were only logging a generic "cancel" message. This was lacking context, specifically which transition causes a cancellation. Here we add a `toString` implementation for `PartitionTransitionProcess` that shows term, role, status and the remaining steps. This is used in a new log statement that should provide us with the necessary context. Co-authored-by: Ole Schönburg <ole.schoenburg@gmail.com>
|
Build failed: |
|
Failed due to #11072 bors r+ |
ghost
pushed a commit
that referenced
this pull request
Nov 22, 2022
11069: feat: log details of cancelled transitions r=oleschoenburg a=oleschoenburg When one transition cancels another, we were only logging a generic "cancel" message. This was lacking context, specifically which transition causes a cancellation. Here we add a `toString` implementation for `PartitionTransitionProcess` that shows term, role, status and the remaining steps. This is used in a new log statement that should provide us with the necessary context. Co-authored-by: Ole Schönburg <ole.schoenburg@gmail.com>
|
Build failed: |
|
bors retry |
ghost
pushed a commit
that referenced
this pull request
Nov 22, 2022
11069: feat: log details of cancelled transitions r=oleschoenburg a=oleschoenburg When one transition cancels another, we were only logging a generic "cancel" message. This was lacking context, specifically which transition causes a cancellation. Here we add a `toString` implementation for `PartitionTransitionProcess` that shows term, role, status and the remaining steps. This is used in a new log statement that should provide us with the necessary context. Co-authored-by: Ole Schönburg <ole.schoenburg@gmail.com>
|
Build failed: |
|
bors retry |
ghost
pushed a commit
that referenced
this pull request
Nov 22, 2022
11069: feat: log details of cancelled transitions r=oleschoenburg a=oleschoenburg When one transition cancels another, we were only logging a generic "cancel" message. This was lacking context, specifically which transition causes a cancellation. Here we add a `toString` implementation for `PartitionTransitionProcess` that shows term, role, status and the remaining steps. This is used in a new log statement that should provide us with the necessary context. Co-authored-by: Ole Schönburg <ole.schoenburg@gmail.com>
|
Build failed: |
|
bors r+ |
|
Build succeeded: |
ghost
merged commit 
|
Successfully created backport PR #11084 for |
|
Successfully created backport PR #11085 for |
ghost
pushed a commit
that referenced
this pull request
Nov 23, 2022
ghost
pushed a commit
that referenced
this pull request
Nov 23, 2022
remcowesterhoud
added
version:8.1.5
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When one transition cancels another, we were only logging a generic "cancel" message. This was lacking context, specifically which transition causes a cancellation.
Here we add a
toStringimplementation forPartitionTransitionProcessthat shows term, role, status and the remaining steps. This is used in a new log statement that should provide us with the necessary context.