Prevent NPE when activating element inside flow scope that's being terminated #11083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
korthout
approved these changes
Nov 23, 2022
...io/camunda/zeebe/engine/processing/processinstance/ModifyProcessInstanceTerminationTest.java
Outdated
Show resolved
Hide resolved
Comment on lines
+1121
to
+1139
| final var rejectedActivateCommand = | ||
| RecordingExporter.processInstanceRecords(ProcessInstanceIntent.ACTIVATE_ELEMENT) | ||
| .withProcessInstanceKey(processInstanceKey) | ||
| .withElementId("endEvent") | ||
| .onlyCommandRejections() | ||
| .getFirst(); | ||
|
|
||
| assertThat(rejectedActivateCommand.getRejectionType()).isEqualTo(RejectionType.INVALID_STATE); | ||
| assertThat(rejectedActivateCommand.getRejectionReason()) | ||
| .isEqualTo( | ||
| "Expected flow scope instance with key '%s' to be present in state but not found.", | ||
| eventSubprocessKey); | ||
| assertThatElementIsTerminated(processInstanceKey, "eventSubProcess"); |
There was a problem hiding this comment.
💭 Although the result is the same, this doesn't fully align with the expected behavior described in the issue:
I can apply the modification. As a result, the end event should be activated. But the whole event subprocess should be terminated because the activation instruction is applied before the termination instruction.
💭 This would be fixed in when Operate disallows this modification as part of Complex Process Instance Modification.
There was a problem hiding this comment.
I believe this is poor wording and it should say that the activate command should be written to the log, as it's an asynchronous action.
…at's being terminated When a modify command contains an activate instruction for an element inside of a subprocess, and also a terminate instruction for the subprocess itself, Zeebe would run into a NullPointer. This is caused by the fact that we keep track of the ancestor keys of an element that's getting activated. We need these to make sure we can clear the interrupted state from any of these ancestors. This is to ensure we support activating elements in an interrupted flow scope. Since we first perform the activate instructions and after this the terminate instructions, we have already terminated the parent of the element that's being activated. We can not get the element instance and potentially remove the interrupted state. A null check needs to be added here.
remcowesterhoud
force-pushed
the
10878_NPE_during_modificatin
branch
from
3e4c6f7
to
8766f41
Compare
|
bors merge |
|
Build succeeded: |
ghost
merged commit 
|
Successfully created backport PR #11087 for |
ghost
pushed a commit
that referenced
this pull request
Nov 23, 2022
remcowesterhoud
added
the
version:8.1.5
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a modify command contains an activate instruction for an element inside of a subprocess, and also a terminate instruction for the subprocess itself, Zeebe would run into a NullPointer.
This is caused by the fact that we keep track of the ancestor keys of an element that's getting activated. We need these to make sure we can clear the interrupted state from any of these ancestors. This is to ensure we support activating elements in an interrupted flow scope.
Since we first perform the activate instructions and after this the terminate instructions, we have already terminated the parent of the element that's being activated. We can not get the element instance and potentially remove the interrupted state. A null check needs to be added here.
Related issues
closes #10878
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
backport stable/1.3) to the PR, in case that fails you need to create backports manually.Testing:
Documentation:
Please refer to our review guidelines.