-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(release): improved input descriptions #11304
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @megglos
thanks for improving the UX. I was thinking how it would look like and checked the result
I felt a bit overwhelm by the text. Maybe we can reorder the fields to have all required on the top and all optional afterward. Plus the optional/required as prefix would (I think) be more helpful. Wdyt?
But I'm also fine with this you can decide.
d59e05c
to
4947ea1
Compare
4947ea1
to
ee58cdd
Compare
bors r+ |
Build succeeded: |
Backport failed for Please cherry-pick the changes locally. git fetch origin stable/8.0
git worktree add -d .worktree/backport-11304-to-stable/8.0 origin/stable/8.0
cd .worktree/backport-11304-to-stable/8.0
git checkout -b backport-11304-to-stable/8.0
ancref=$(git merge-base 565efaf891a5ac6fe0f6271fdb0c726d3080463d ee58cdd7a84c5903ce3b291cb4dc001db55faad6)
git cherry-pick -x $ancref..ee58cdd7a84c5903ce3b291cb4dc001db55faad6 |
Backport failed for Please cherry-pick the changes locally. git fetch origin stable/8.1
git worktree add -d .worktree/backport-11304-to-stable/8.1 origin/stable/8.1
cd .worktree/backport-11304-to-stable/8.1
git checkout -b backport-11304-to-stable/8.1
ancref=$(git merge-base 565efaf891a5ac6fe0f6271fdb0c726d3080463d ee58cdd7a84c5903ce3b291cb4dc001db55faad6)
git cherry-pick -x $ancref..ee58cdd7a84c5903ce3b291cb4dc001db55faad6 |
Description
Improved descriptions for the Release job inputs as well as revised order and defaults (e.g. letting dryRun to default to false now, as from a release managers perspective that is the desired value). In order to make the ease of use better.
I prefixed all input descriptions with the name of the input itself, this helped to easier refer to inputs e.g. from the instructions within the release process forms.
Related issues
closes #11303