Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: ensure PKCS1 support with REST #17216

Merged
merged 3 commits into from
Apr 17, 2024
Merged

test: ensure PKCS1 support with REST #17216

merged 3 commits into from
Apr 17, 2024

Conversation

npepinpe
Copy link
Member

@npepinpe npepinpe commented Apr 2, 2024

Description

This PR ensures we keep compatibility of PKCS1 private keys even with the REST API.

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. backport stable/1.3) to the PR, in case that fails you need to create backports manually.

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually
  • The change has been verified by a QA run
  • The impact of the changes is verified by a benchmark

Documentation:

  • The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
  • If the PR changes how BPMN processes are validated (e.g. support new BPMN element) then the Camunda modeling team should be informed to adjust the BPMN linting.

Other teams:
If the change impacts another team an issue has been created for this team, explaining what they need to do to support this change.

Please refer to our review guidelines.

@npepinpe npepinpe requested a review from tmetzke April 2, 2024 08:06
@npepinpe npepinpe self-assigned this Apr 2, 2024
@github-actions github-actions bot added the component/zeebe Related to the Zeebe component/team label Apr 2, 2024
tmetzke
tmetzke approved these changes Apr 2, 2024
View reviewed changes
Copy link
Member

@tmetzke tmetzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me.
🔧 I added a formatting suggestion.

zeebe/qa/integration-tests/src/test/java/io/camunda/zeebe/it/security/Pkcs1SupportTest.java Outdated Show resolved Hide resolved
@npepinpe npepinpe enabled auto-merge April 2, 2024 08:28
@npepinpe npepinpe added the backport stable/8.5 Backport a pull request to stable/8.5 label Apr 12, 2024
npepinpe and others added 3 commits April 17, 2024 14:47
@npepinpe
test: ensure PKCS1 support with REST
a57d217
@npepinpe @tmetzke
style: apply formatting
4643950 
Co-authored-by: Tobias Metzke-Bernstein <586643+tmetzke@users.noreply.github.com>
@npepinpe
style: remove weird characters introduced
4c16354
@npepinpe npepinpe added this pull request to the merge queue Apr 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 17, 2024
@npepinpe npepinpe added this pull request to the merge queue Apr 17, 2024
Merged via the queue into main with commit 0c19864 Apr 17, 2024
39 checks passed
@npepinpe npepinpe deleted the np-pkcs1-rest branch April 17, 2024 15:03
@backport-action backport-action mentioned this pull request Apr 17, 2024
Merged
@backport-action
Copy link
Collaborator

Successfully created backport PR for stable/8.5:

@github-actions GitHub Actions
Copy link
Contributor

Git push to origin failed for stable/8.5 with exitcode 1

github-merge-queue bot pushed a commit that referenced this pull request Apr 17, 2024
@npepinpe
[Backport stable/8.5] test: ensure PKCS1 support with REST (#17551)
73cfd96 
# Description
Backport of #17216 to `stable/8.5`.

relates to
original author: @npepinpe
@Zelldon Zelldon added the version:8.5.1 Marks an issue as being completely or in parts released in 8.5.1 label May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmetzke tmetzke tmetzke approved these changes

Assignees

@npepinpe npepinpe

Labels
backport stable/8.5 Backport a pull request to stable/8.5 component/zeebe Related to the Zeebe component/team version:8.5.1 Marks an issue as being completely or in parts released in 8.5.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@npepinpe @backport-action @tmetzke @Zelldon