fix: delete existing ISM policy when retention is disabled #17386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is a tryout to fix the OpensearchExporterIT flaky test, but it could be also solving an existing unnoticed bug
mustafadagher
added
kind/flake
megglos
approved these changes
Apr 9, 2024
| "DELETE", "_plugins/_ism/policies/" + configuration.retention.getPolicyName()); | ||
|
|
||
| final var response = sendRequest(request, DeleteStateManagementPolicyResponse.class); | ||
| return response.result().equals(DeleteStateManagementPolicyResponse.DELETED); |
There was a problem hiding this comment.
❓ so in case it doesn't exist this does not end up in a 404 but just returns a result. The API docs don't really answer that :/ but tests do:D
megglos
added
backport stable/8.4
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin stable/8.4
git worktree add -d .worktree/backport-17386-to-stable/8.4 origin/stable/8.4
cd .worktree/backport-17386-to-stable/8.4
git switch --create backport-17386-to-stable/8.4
git cherry-pick -x 8f11aae6905fff244bae6cdb689ec12e28f5159e |
|
Successfully created backport PR for |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 10, 2024
…is disabled (#17410) # Description Backport of #17386 to `stable/8.5`. relates to #17279 original author: @mustafadagher
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 11, 2024
…is disabled (#17418) # Description Backport of #17386 to `stable/8.4`. relates to #17279 original author: @mustafadagher
Zelldon
added
version:8.4.7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Delete existing ISM policy when retention is disabled. This is a tryout to fix the OpensearchExporterIT flaky test, but it could be also solving an existing unnoticed bug
Related issues
closes #17279