Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: disable flake BackupUploadIT.shouldSaveBackupWithManyFiles #18205

Merged
merged 1 commit into from
May 3, 2024
Merged

test: disable flake BackupUploadIT.shouldSaveBackupWithManyFiles #18205

merged 1 commit into from
May 3, 2024

Conversation

megglos
Copy link
Contributor

@megglos megglos commented May 3, 2024 •
edited
Loading

Description

To mitigate disruption and continue investigation in isolation as it's easily reproducable.

Related issues

related to #18177

@github-actions github-actions bot added the component/zeebe Related to the Zeebe component/team label May 3, 2024
@megglos
test: disable flake BackupUploadIT.shouldSaveBackupWithManyFiles
4eacb2e 
To mitigate disruption and continue investigation in isolation.
@megglos megglos requested a review from korthout May 3, 2024 10:11
korthout
korthout approved these changes May 3, 2024
View reviewed changes
Copy link
Member

@korthout korthout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good solution to me 👍

❌ Please also have someone from ZDP review this

@megglos
Copy link
Contributor Author

megglos commented May 3, 2024 •
edited
Loading

❌ Please also have someone from ZDP review this

what do you mean by that? the change is only disabling the test. We won't halt working on this flake I will take care we continue the investigation next week, if that's what you mean.

@megglos megglos added this pull request to the merge queue May 3, 2024
@korthout
Copy link
Member

korthout commented May 3, 2024

We won't halt working on this flake I will take care we continue the investigation next week, if that's what you mean.

Sorry, on second thought that makes much more sense! Let's merge this and keep the issue open

@megglos megglos mentioned this pull request May 3, 2024
Closed
Merged via the queue into main with commit 3884e29 May 3, 2024
39 checks passed
@megglos megglos deleted the meg-18177-disable-flake branch May 3, 2024 10:27
rodrigo-lourenco-lopes
rodrigo-lourenco-lopes reviewed May 3, 2024
View reviewed changes
Copy link
Contributor

@rodrigo-lourenco-lopes rodrigo-lourenco-lopes left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will try to take a look at this issue if I have time today 👍

@rodrigo-lourenco-lopes rodrigo-lourenco-lopes added backport stable/8.2 backport stable/8.3 Backport a pull request to 8.3.x backport stable/8.4 Backport a pull request to 8.4.x backport stable/8.5 Backport a pull request to stable/8.5 labels May 5, 2024
@rodrigo-lourenco-lopes
Copy link
Contributor

/backport

@backport-action backport-action mentioned this pull request May 5, 2024
Merged
@backport-action
Copy link
Collaborator

Successfully created backport PR for stable/8.2:

@backport-action
Copy link
Collaborator

Successfully created backport PR for stable/8.3:

@backport-action backport-action mentioned this pull request May 5, 2024
Merged
@backport-action
Copy link
Collaborator

Successfully created backport PR for stable/8.4:

This was referenced May 5, 2024
Merged
Merged
@backport-action
Copy link
Collaborator

Successfully created backport PR for stable/8.5:

github-merge-queue bot pushed a commit that referenced this pull request May 5, 2024
@camundait
[Backport stable/8.2] test: disable flake BackupUploadIT.shouldSaveBa…
254cfc5 
…ckupWithManyFiles (#18241)

# Description
Backport of #18205 to `stable/8.2`.

relates to #18177
original author: @megglos
github-merge-queue bot pushed a commit that referenced this pull request May 5, 2024
@camundait
[Backport stable/8.4] test: disable flake BackupUploadIT.shouldSaveBa…
b8b9fe1 
…ckupWithManyFiles (#18243)

# Description
Backport of #18205 to `stable/8.4`.

relates to #18177
original author: @megglos
github-merge-queue bot pushed a commit that referenced this pull request May 5, 2024
@camundait
[Backport stable/8.3] test: disable flake BackupUploadIT.shouldSaveBa…
607574a 
…ckupWithManyFiles (#18242)

# Description
Backport of #18205 to `stable/8.3`.

relates to #18177
original author: @megglos
github-merge-queue bot pushed a commit that referenced this pull request May 5, 2024
@camundait
[Backport stable/8.5] test: disable flake BackupUploadIT.shouldSaveBa…
876618d 
…ckupWithManyFiles (#18244)

# Description
Backport of #18205 to `stable/8.5`.

relates to #18177
original author: @megglos
@Zelldon Zelldon added version:8.2.27 Marks an issue as being completely or in parts released in 8.2.27 version:8.4.7 Marks an issue as being completely or in parts released in 8.4.7 version:8.5.1 Marks an issue as being completely or in parts released in 8.5.1 version:8.3.11 Marks an issue as being completely or in parts released in 8.3.11 labels May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodrigo-lourenco-lopes rodrigo-lourenco-lopes rodrigo-lourenco-lopes left review comments

@korthout korthout korthout approved these changes

Assignees
No one assigned
Labels
backport stable/8.3 Backport a pull request to 8.3.x backport stable/8.4 Backport a pull request to 8.4.x backport stable/8.5 Backport a pull request to stable/8.5 component/zeebe Related to the Zeebe component/team version:8.2.27 Marks an issue as being completely or in parts released in 8.2.27 version:8.3.11 Marks an issue as being completely or in parts released in 8.3.11 version:8.4.7 Marks an issue as being completely or in parts released in 8.4.7 version:8.5.1 Marks an issue as being completely or in parts released in 8.5.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@megglos @korthout @rodrigo-lourenco-lopes @backport-action @Zelldon