fix: do not retry create instance on closed connection

[megglos]

Description

This replaces ConnectionException throws in cases where a connection was actually established previously with a more appropriate MessagingException.ConnectionClosed, as ConnectionException is only supposed to be used in cases where a connection couldn't get established at all, see https://docs.oracle.com/javase%2F7%2Fdocs%2Fapi%2F%2F/java/net/ConnectException.html.

Related issues

closes #17333

[megglos]

failed state is just due to a failed benchmark setup caused by the excessive branch name 🙃

[megglos]

I created a generation Zeebe PR 18264 based on this on integration and ran the https://github.com/pierre-yves-monnet/c8-highcreation test project against a cluster running it, it created 10k instances without a duplicate detected.

[npepinpe]

There's no test for the NettyMessagingService change, but I can see that's difficult to test in a controlled way 🤔 Let's go with this 👌

Nice catch!

[backport-action]

Backport failed for stable/8.2, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin stable/8.2
git worktree add -d .worktree/backport-18264-to-stable/8.2 origin/stable/8.2
cd .worktree/backport-18264-to-stable/8.2
git switch --create backport-18264-to-stable/8.2
git cherry-pick -x 9b68e0937b3c2942cdda9372469e5facb1808158

[backport-action]

Successfully created backport PR for stable/8.3:

• [Backport stable/8.3] fix: do not retry create instance on closed connection #18282

[backport-action]

Successfully created backport PR for stable/8.4:

• [Backport stable/8.4] fix: do not retry create instance on closed connection #18283

[backport-action]

Successfully created backport PR for stable/8.5:

• [Backport stable/8.5] fix: do not retry create instance on closed connection #18284