Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove temporary cache cleaning fix from OS smoke tests #8943

Merged
merged 1 commit into from
Mar 21, 2022

Conversation

npepinpe
Copy link
Member

Description

This PR removes the temporary cache cleaning actions from the OS smoke tests. It doesn't seem to be doing much at this point, as we still regularly run into issues with it. Let's go with the "standard" cache action and start again when we see issues.

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. backport stable/1.3) to the PR, in case that fails you need to create backports manually.

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually
  • The change has been verified by a QA run
  • The impact of the changes is verified by a benchmark

Documentation:

  • The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
  • New content is added to the release announcement
  • If the PR changes how BPMN processes are validated (e.g. support new BPMN element) then the Camunda modeling team should be informed to adjust the BPMN linting.

Copy link
Member

@lenaschoenburg lenaschoenburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@npepinpe
Copy link
Member Author

bors merge

ghost pushed a commit that referenced this pull request Mar 21, 2022
8943: Remove temporary cache cleaning fix from OS smoke tests r=npepinpe a=npepinpe

## Description

This PR removes the temporary cache cleaning actions from the OS smoke tests. It doesn't seem to be doing much at this point, as we still regularly run into issues with it. Let's go with the "standard" cache action and start again when we see issues.



Co-authored-by: Nicolas Pepin-Perreault <nicolas.pepin-perreault@camunda.com>
@ghost
Copy link

ghost commented Mar 21, 2022

Build failed:

@npepinpe npepinpe merged commit b18da9b into main Mar 21, 2022
@npepinpe npepinpe deleted the np-remove-cache-cleaning branch March 21, 2022 14:28
@github-actions
Copy link
Contributor

Git push to origin failed for stable/1.2 with exitcode 1

@github-actions
Copy link
Contributor

Git push to origin failed for stable/1.3 with exitcode 1

@npepinpe
Copy link
Member Author

That's a new one. I didn't even get the commands I need to paste :( @korthout

ghost pushed a commit that referenced this pull request Mar 21, 2022
8947: [Backports stable/1.2] Remove temporary cache cleaning r=oleschoenburg a=npepinpe

## Description

This PR backports #8943 to stable/1.2.

## Related issues

backports #8943



Co-authored-by: Nicolas Pepin-Perreault <nicolas.pepin-perreault@camunda.com>
@korthout
Copy link
Member

korthout commented Mar 21, 2022

That's a new one. I didn't even get the commands I need to paste :( @korthout

(refusing to allow a GitHub App to create or update workflow .github/workflows/os-smoke-test.yml without workflows permission)

Yeah this is a permissions topic. If we want it to be able to backport changes to workflow files, then we need to explicitly give it the permission to do so. We could consider that 🤔 What do you think? @npepinpe

ghost pushed a commit that referenced this pull request Mar 21, 2022
8946: [Backports stable/1.3] Remove temporary cache cleaning r=oleschoenburg a=npepinpe

## Description

This PR backports #8943 to stable/1.3.

## Related issues

backports #8943



Co-authored-by: Nicolas Pepin-Perreault <nicolas.pepin-perreault@camunda.com>
@npepinpe npepinpe added the version:1.2.12 Marks an issue as being completely or in parts released in 1.2.12 label Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
version:1.2.12 Marks an issue as being completely or in parts released in 1.2.12
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants