fix(broker): do not log transition failure due to term mismatch as error #9122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Zelldon
reviewed
Apr 13, 2022
There was a problem hiding this comment.
Thanks @deepthidevaki lets shortly clarify the question below and then we good to go
...src/main/java/io/camunda/zeebe/broker/system/partitions/impl/PartitionTransitionProcess.java
Outdated
Show resolved
Hide resolved
Zelldon
reviewed
Apr 13, 2022
broker/src/main/java/io/camunda/zeebe/broker/system/partitions/ZeebePartition.java
Outdated
Show resolved
Hide resolved
If a transition failed due to a term mismatch, there will be a new transition following. There is no need to log it as an error because conceptually it is not an error. It is expected to fail to prevent inconsistencies. When this failure happens, it is ignored and ZeebePartition continue with the next transition.
deepthidevaki
force-pushed
the
dd-9040-error-log-partition
branch
from
e061f95
to
713d2ee
Compare
|
bors merge |
ghost
merged commit 
|
Successfully created backport PR #9124 for |
|
Successfully created backport PR #9125 for |
ghost
pushed a commit
that referenced
this pull request
Apr 13, 2022
ghost
pushed a commit
that referenced
this pull request
Apr 13, 2022
9125: [Backport stable/8.0] fix(broker): do not log transition failure due to term mismatch as error r=deepthidevaki a=github-actions[bot] # Description Backport of #9122 to `stable/8.0`. relates to #9040 9133: [Backport stable/8.0] Prevent duplicate key insertion for DMN r=remcowesterhoud a=github-actions[bot] # Description Backport of #9121 to `stable/8.0`. relates to #9115 Co-authored-by: Deepthi Devaki Akkoorath <deepthidevaki@gmail.com> Co-authored-by: Remco Westerhoud <remco@westerhoud.nl>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If a transition failed due to a term mismatch, there will be a new transition following. There is no need to log it as an error because conceptually it is not an error. It is expected to fail to prevent inconsistencies. When this failure happens, it is ignored and ZeebePartition continue with the next transition.
Related issues
closes #9040
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
backport stable/1.3) to the PR, in case that fails you need to create backports manually.Testing:
Documentation: