Refactor ElasticsearchClient unit tests #9358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npepinpe
force-pushed
the
9330-client-unit
branch
from
10190be
to
deb73bf
Compare
|
I think the CodeQL stuff can be ignored for this review as it's just repeating the existing alerts (for some reason) 🤔 |
10 tasks
npepinpe
force-pushed
the
9330-client-unit
branch
from
deb73bf
to
4cd7eb8
Compare
|
Now there's a flaky update test, but I don't see how this PR would have affected it. |
saig0
approved these changes
May 30, 2022
|
bors merge |
ghost
pushed a commit
that referenced
this pull request
May 30, 2022
9358: Refactor ElasticsearchClient unit tests r=saig0 a=npepinpe ## Description This PR refactors the `ElasticsearchClient` unit tests to cover what the client is now responsible for: flushing and flushing logic, and communication with Elastic. This removes one unit tests which was previously in `ElasticsearchClientIT`, and removes the `ElasticsearchExporterFlushTest`, which are now simply nested in `ElasticsearchClientTest`. ## Related issues closes #9330 Co-authored-by: Nicolas Pepin-Perreault <nicolas.pepin-perreault@camunda.com>
|
Build failed: |
|
Some flaky tests related to containers running out of memory :( bors retry |
ghost
pushed a commit
that referenced
this pull request
May 30, 2022
9358: Refactor ElasticsearchClient unit tests r=saig0 a=npepinpe ## Description This PR refactors the `ElasticsearchClient` unit tests to cover what the client is now responsible for: flushing and flushing logic, and communication with Elastic. This removes one unit tests which was previously in `ElasticsearchClientIT`, and removes the `ElasticsearchExporterFlushTest`, which are now simply nested in `ElasticsearchClientTest`. ## Related issues closes #9330 Co-authored-by: Nicolas Pepin-Perreault <nicolas.pepin-perreault@camunda.com>
|
Build failed: |
|
Same issue again :( Merging manually as bors is currently silent, and I'm pretty sure this PR did not affect the integration tests. |
Zelldon
added
the
version:8.1.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the
ElasticsearchClientunit tests to cover what the client is now responsible for: flushing and flushing logic, and communication with Elastic.This removes one unit tests which was previously in
ElasticsearchClientIT, and removes theElasticsearchExporterFlushTest, which are now simply nested inElasticsearchClientTest.Related issues
closes #9330
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
backport stable/1.3) to the PR, in case that fails you need to create backports manually.Testing:
Documentation:
Please refer to our review guidelines.