Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky shouldNotifyCommitListener test #9518

Merged
3 commits merged into from
Jun 8, 2022
Merged

Fix flaky shouldNotifyCommitListener test #9518

3 commits merged into from
Jun 8, 2022

Conversation

deepthidevaki
Copy link
Contributor

@deepthidevaki deepthidevaki commented Jun 7, 2022

Description

Use commitIndex to verify that listener is notified instead of using called count. It is possible that one of the follower committed the InitialEntry after the CommitListener is added. As a result the test failed because the expected call count is different.

Related issues

closes #9372

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. backport stable/1.3) to the PR, in case that fails you need to create backports manually.

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually
  • The change has been verified by a QA run
  • The impact of the changes is verified by a benchmark

Documentation:

  • The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
  • New content is added to the release announcement
  • If the PR changes how BPMN processes are validated (e.g. support new BPMN element) then the Camunda modeling team should be informed to adjust the BPMN linting.

Please refer to our review guidelines.

Use commitIndex to verify that listener is notified instead of using called count. It is possible that one of the follower committed the InitialEntry after the CommitListener is added. As a result the test failed because the expected call count is different.
@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2022

Unit Test Results

   777 files  ±  0     777 suites  ±0   1h 34m 50s ⏱️ + 2m 10s
5 625 tests +18  5 618 ✔️ +18  7 💤 ±0  0 ±0 
5 795 runs  +18  5 788 ✔️ +18  7 💤 ±0  0 ±0 

Results for commit 602bab6. ± Comparison against base commit ff1b36f.

Copy link
Member

@Zelldon Zelldon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

bors r+

@ghost
Copy link

ghost commented Jun 8, 2022

Build succeeded:

@ghost ghost merged commit 80e40b7 into main Jun 8, 2022
@ghost ghost deleted the dd-9372-raft-test branch June 8, 2022 13:50
@backport-action
Copy link
Collaborator

Successfully created backport PR #9524 for stable/8.0.

ghost pushed a commit that referenced this pull request Jun 8, 2022
9524: [Backport stable/8.0] Fix flaky shouldNotifyCommitListener test r=deepthidevaki a=backport-action

# Description
Backport of #9518 to `stable/8.0`.

relates to #9372

Co-authored-by: Deepthi Devaki Akkoorath <deepthidevaki@gmail.com>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky io.atomix.raft.zeebe.ZeebeTest:shouldNotifyCommitListeners
4 participants