Basic home page with palceholders #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxbi
reviewed
Jan 27, 2023
| @@ -3,9 +3,37 @@ | |||
| <head> | |||
| {% include "includes/header.html" %} | |||
| <meta charset="UTF-8"> | |||
| <title>Title</title> | |||
| <title>jacob.covs.tld</title> <!-- TEMP:REPLACE --> | |||
There was a problem hiding this comment.
We'll need to make some config file that constants like this get pulled from. OK for now
| <title>Title</title> | ||
| <title>jacob.covs.tld</title> <!-- TEMP:REPLACE --> | ||
|
|
||
| <div class="container"> |
There was a problem hiding this comment.
Pull out navbar into templates/includes/navbar.html, which we can then do {% include "includes/navbar.html" %} within each page.
There was a problem hiding this comment.
I was going to, but that assumes that the navbar will be the same on each page, which it won't be:
The current page's highlighting needs changing, and which options are available need to be changed.
Would this still work anyway (i.e. can we dynamically change things in the included navbar.html ?) ??
| <!-- Bootstrap: --> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1"> | ||
| <link href="https://cdn.jsdelivr.net/npm/bootstrap@5.3.0-alpha1/dist/css/bootstrap.min.css" rel="stylesheet" integrity="sha384-GLhlTQ8iRABdZLl6O3oVMWSktQOp6b7In1Zl3/Jr59b6EGGoI1aFkw7cmDA6j6gD" crossorigin="anonymous"> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.