Update expander row 1.4 and make more properties accessible #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expanded enableExpansion showEnableSwitch titleLines subtitleLines All of these properties were not yet wrapped.
can-lehmann
requested changes
Nov 13, 2023
property hooks always get executed at least once, even if the value is never set. Therefore you shouldn't automatically throw an exception in a hook.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I was debugging ExpanderRow I noticed a couple properties weren't wrapped, so I added them.
Also in order to be able to have 2 way bindings for the "expanded" property (since you can set it while also influencing it from the user side by interacting with the widget) I added an event-listener for the "expannded" property.
Possibly not too valuable, but makes the wrapping around the row more "complete" in my eyes.
This also prepares ExpanderRow for higher adwaita versions, as
adw_expander_row_add_actionwas deprecated in favour ofadw_expander_row_add_suffixin Adwaita 1.4.